Comments (102)
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
Though you should probably leave a cut of 1.0 available for download.
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
👍
from jquery-ui-bootstrap.
@sindresorhus how on earth did you do that?!
+1 although if you like 1.0 then theres no harm in sticking with that I guess
from jquery-ui-bootstrap.
using this code ````
👍
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
@studioromeo GitHub has emoji support 💪
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
👍
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
🐳
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1 coz i need to play with new features now and i couldnt wait.
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
👍
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
👍
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
👍
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1 and Bootstrap 2.0 is final now
from jquery-ui-bootstrap.
++1
from jquery-ui-bootstrap.
+2.0
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
I love the responsive design support.
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
-1 (just kidding)
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
👍
from jquery-ui-bootstrap.
@addyosmani I did some briefly integration of jquery ui bootstrap with bootstrap 2 but I didn't changed the custom jquery ui theme I just added bootstrap 2 css and js...
The big work is to convert old jquery ui theme to look more like bootstrap 2.0 theme.
Maybe I'll work a bit more on that and dedicate some time on it.
The good part also is that now you don't need to hack bootstrap css files because it seems it don't break anything in jquery ui, it was plug-and-play so far with my tests.
You can check a preview here nothing impressive so far, just playing around...
EDIT:
@addyosmani maybe jquery ui bootstrap theme should be made with less in order to get bootstrap's variables and use them instead of hard-coding them, this will make the upgrade easier for future changes of bootstrap.
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
@panosru You raise a very valid point. One of the issues with building the first version was a heavy reliance on custom matching color schemes and where possible, I'd like to avoid this for the next version. I'm not the biggest fan in the world of LESS, but I'll try to experiment with it as an option :) It would definitely make maintaining sync with future versions of Bootstrap a lot easier than it is now.
You may remember seeing a previous PR with a LESS version of the theme. Given that there are still some components in Bootstrap 2 that haven't hugely changed, do you think it's worth cleaning that up and using it as a base or starting from scratch?
from jquery-ui-bootstrap.
@addyosmani Not only it would make maintaining new versions of bootstrap easier but as you noticed bootstrap 2 provides the ability of customization as a result if I customize my version of bootstrap then jquery ui bootstrap theme will adopt on my settings. I'm not really sure about that though because so far from what I noticed is that the customization tool generate's css and not less files, but either-way at least maintaining would be much easier to do.
Yes I remember you talking about Pull #41 by @t1gr0u I did a check again on that and it seems already good to me, I would prefer to start from that instead of from scratch (even if generally I always prefer to do things from scratch) I guess it worth of working on it for bootstrap 2 integration.
Another point I want to mention is that we shouldn't touch bootstrap's code, what I mean is that for instance in jquery ui bootstrap 1 some bootstrap css break some our jquery interface etc so we had to touch bootstrap's [le|c]ss files, I would suggest instead to have a style.less
which would @import bootstrap.less
and after that @import jquery-ui-bootstrap.less
so we could override anything we need from bootstrap without interacting with core files of bootstrap, this will also help us for better maintenance, and better overlook of changes we did. So far that I test bootstrap2 with jquery ui bootstrap seems that bootstrap 2 works fine with jquery ui theme and does not break anything, so no overriding is needed.
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
hi @panosru, @addyosmani,
let me if I can be any help on the LESS files
from jquery-ui-bootstrap.
This might be a good starting point, only if I'm not missing the point completely :)
https://github.com/svnlto/jQueryUILess
from jquery-ui-bootstrap.
@svnlto I prefer to break apart @t1gr0u 's less file since he already added the variables in his less file so it would be much easier :) but this could be a good example on how we should abstract our theme in order to have a better scope of the code :)
from jquery-ui-bootstrap.
Also something about +1, I believe no more +1 are needed, we got the point now what is needed is contribution to make it happen :)
from jquery-ui-bootstrap.
breaking the files would be good
from jquery-ui-bootstrap.
simply: +1
from jquery-ui-bootstrap.
i've broke down the LESS file: https://github.com/t1gr0u/jquery-ui-bootstrap
from jquery-ui-bootstrap.
@t1gr0u good work! I like it like that :)
from jquery-ui-bootstrap.
it make easier to work on and to update :)
from jquery-ui-bootstrap.
@t1gr0u good work!
from jquery-ui-bootstrap.
@panosru , @svnlto thank you :)
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
+1
from jquery-ui-bootstrap.
@panosru Due to the number of votes we're continuing to receive on this and the fact the decision is now unanimous I think I'm going to close this thread and open a new one for 2.0 discussions solely.
from jquery-ui-bootstrap.
Related Issues (20)
- I find a bug
- Widget size limit influencing the Google Map appearance
- SASS Parser
- node server.js start errors HOT 1
- Update bower HOT 1
- Sass instead of LESS
- Remove transition on ui-slider-range
- Can newer version of jqueryui be used in place of jquery-ui-1.10.0.custom.min?
- standardize naming on css includes in custom-theme
- Why include jQuery files HOT 1
- Webjars
- update
- When I try to drag a dialog box in the demo, it disappears.
- The Navbar button doesn't work in the demo with a small viewport.
- cdn.js out of date
- hello brother of good can help me with one thing
- Repo abandoned? HOT 2
- I think you need a Chinese UserGuide HOT 1
- Bootstrap 3, 4 support
- jquery-ui-bootstrap and bootstrap bootstrap grid css not able to use
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-ui-bootstrap.