Coder Social home page Coder Social logo

Comments (4)

jpsca avatar jpsca commented on August 26, 2024 1

You really like to use comments! 😄
But seriously, thank you for the bug report.
I've just published a fix:
https://github.com/jpsca/jinjax/releases/tag/0.43

from jinjax.

jpsca avatar jpsca commented on August 26, 2024

I had no idea people did this, or that it worked at all 😮 ... but I'm going to investigate what changed

from jinjax.

jpsca avatar jpsca commented on August 26, 2024

@JakobGM It should be no longer necessary to remove the comments: https://github.com/jpsca/jinjax/releases/tag/0.41

from jinjax.

JakobGM avatar JakobGM commented on August 26, 2024

Thanks, @jpsca!

There seems to be a new regression introduced in 0.41, most likely introduced by your new fix 😅 It is triggered when the first structure after the component argument list is a comment block. Here is an example:

{# def
  arg,
#}

{#
  Some comment.
#}

The p = ast.parse(f"def component(*, {expr}): pass") line in JinjaX tries to parse def component(*, arg_1, {#): pass. Let me know if you can't reproduce it (I simplified by code example somewhat).

from jinjax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.