Coder Social home page Coder Social logo

Comments (5)

jpodwys avatar jpodwys commented on May 27, 2024

Hi, I'm glad you're finding the library useful!

If I understand you correctly, you'd like cache-service-redis to depend on [email protected]. This package's dependency on node_redis is a relative pin: "redis": "^2.6.2". I just installed it to be certain and it does indeed install [email protected].

If you're not seeing that, then please simply update your installation. Please let me know if I've misunderstood.

from cache-service-redis.

autorTepatiki avatar autorTepatiki commented on May 27, 2024

Hi. As the package "redis" is not been tagged since 2 years ago, it doesnt include the rediss:// protocol nor TLS, fundamental pieces to connect to ElasticCache. My question tried to address this point, trying to see if the dependency in your package could be changed directly to an own fork from Github (master branch of "redis") to get those changes reflected. This would be "A" plan, because the other library that really supports rediss:// (TLS) is "ioredis", but this will be a mayor change in your repo I think.

from cache-service-redis.

jpodwys avatar jpodwys commented on May 27, 2024

Thank you for helping me to understand, I didn't realize that there hasn't been a release in over two years.

I'm uncomfortable pinning the master branch of cache-service-redis to the master branch of node_redis.

Here are two possible solutions:

  1. I'd like to cut a new major release (3.0.0) that would switch to ioredis. I'm not certain how much work is involved, but I just switched to ioredis locally and all of my unit tests still pass. I'm guessing it breaks things somewhere, but I need to investigate more.
  2. If you can't wait for/contribute to such a release, then please feel free to fork both repos and pin to your forks in the mean time.

What do you think?

from cache-service-redis.

autorTepatiki avatar autorTepatiki commented on May 27, 2024

Yes, that is. Both options are fine to me, Plan 1 + plan 2. Thank you very much.

from cache-service-redis.

jpodwys avatar jpodwys commented on May 27, 2024

@martindcernadas I haven't yet had time to update this beyond running the unit tests with ioredis. I noticed that you made a fork and switched to ioredis. I'm curious if you've used it. If so, how is it functioning for you?

from cache-service-redis.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.