Coder Social home page Coder Social logo

Comments (4)

joshware avatar joshware commented on July 24, 2024 1

Wow, with that bug I'm surprised it worked at all. Sorry about that, my bad.

Though the missing effect is interesting, I'll look into it and see what I can dig up. Maybe it's that unknown alist call

from lazyusf2.

derselbst avatar derselbst commented on July 24, 2024

Hi, thanks for looking into this.

The resonant IIR low-pass-filter heard in sparse3d (RockSolid) works well, since @joshware has fixed it a few years ago. I believe this is a different issue, which never worked before.

When you inspect the MIDI of e.g. sparse41, you'll find that Mr. Beanland has placed a CC35 with value 10 into channel 2 (zero-based counting). This will trigger some kind of "overdrive" effect heard in the very first seconds of the song.

That same instrument is playing again ~19 seconds, this time however it's on channel 5, and CC35 is set to a value of 0. RockSolid also implicitly keeps CC35 at 0, hence CC35=0 means "IIR low-pass filter". But what does CC35=10 mean?

With HLE enabled, your plugin will even output an error like unknown audio command: 00000 bla.

The crash that you experienced may be due to a bug in Josh's original IIR HLE implementation. It has been fixed at mupen64plus: mupen64plus/mupen64plus-rsp-hle/pull/83

from lazyusf2.

kode54 avatar kode54 commented on July 24, 2024

Yeah, I found the problem with my code. Beside that crash bug being fixed, I was also spuriously logging all warnings, which also broke execution of the emulator. I've disabled warn logging now.

from lazyusf2.

derselbst avatar derselbst commented on July 24, 2024

Sorry @kode54, but while your recent findings improve the situation, it still sounds different to LLE: That overdrive effect I described is completely missing in HLE.

from lazyusf2.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.