Unit Tests about node-pureimage

[joshmarinacci]

Absolutely! Thank you! Sent from planet Earth

…

On Nov 25, 2017, at 11:49 PM, Robert Main ***@***.***> wrote: Can I look at straightening the tests out? I've already started to put something together locally - but (with your approval) I'll continue and start putting a PR together? :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[robertmain]

Cool - I've had a look at using jest in the place of tape. Reason being is that (in my opinion) it produces better readable test output, it supports mocking and it's easier to configure (pretty much no config out of the box).

The syntax looks like this:

const Point = require('../../src/Point');
const Line  = require('../../src/Line');

describe('Line', () => {

    it('created from two points use them as start and end points', () => {
        let start = new Point(6, 8);
        let end   = new Point(12, 6);

        expect(() => new Line(start, end)).not.toThrow(TypeError);
        expect(() => new Line(6, 8)).toThrow();
    });

    it('created from 4 ordinates uses them as start and end points', () => {
        expect(() => new Line(6, 8, 12, 6)).not.toThrow();
        expect(() => new Line({}, "spaghetti", "hello world", [])).toThrow(TypeError);
    });

    it('can only be created with either 2 or 4 arguments', () => {
        let errorMsg = 'Please pass either two Point objects, or 4 integers to the constructor';

        expect(() => new Line()).toThrow(errorMsg);
        expect(() => new Line(12)).toThrow(errorMsg);
        expect(() => new Line(12, 30, 92)).toThrow(errorMsg);
        expect(() => new Line(12, 30, 92, 10, 99)).toThrow(errorMsg);
    });

    it('is the distance between two points', () => {
        let start = new Point(6, 8);
        let end   = new Point(0, 0);

        let line  = new Line(start, end);

        expect(line.getLength()).toBe(10);
    })
});

Which produces output that looks like this:

[robertmain]

Forgot to mention - it also supports mocking too, which might be nice when dealing with dependencies between objects like Context and Bitmap

[robertmain]

@joshmarinacci - I'm just busy converting some of the existing tests into unit tests...I was wondering what this did:

var PImage = require('../src/pureimage');

{

    // compositing tests
    // red onto white
    eq(PImage.compositePixel(0xFF0000FF, 0xFFFFFFFF), 0xFF0000FF);
    // blue onto white
    eq(PImage.compositePixel(0x00FF00FF, 0xFFFFFFFF), 0x00FF00FF);
    // red onto black
    eq(PImage.compositePixel(0xFF0000FF, 0x000000FF), 0xFF0000FF);
    // red 50% onto black
    eq(PImage.compositePixel(0xFF00007F, 0x000000FF), 0x7F0000FF);
}

function eq(a,b) {
    if(a != b) throw new Error(a.toString(16) + " is not equal to " + b.toString(16));
}
function dumpBytes(img) {
    for(var i=0; i<10; i++) {
        console.log(i,img._buffer[i].toString(16));
    }
}

It's clearly testing the compositePixel method - but I'm not quite sure what that method does - I also can't seem to find it in the library anywhere...unless it's referring to the composite method in the Bitmap class?

[joshmarinacci]

Honestly I don't remember. An earlier version of pure image had a compositingPixel function, though it didn't work correctly. You can just skip these for now. We'll make new ones.

…

-j

On Nov 28, 2017, at 9:24 PM, Robert Main ***@***.***> wrote: @joshmarinacci <https://github.com/joshmarinacci> - I'm just busy converting some of the existing tests into unit tests...I was wondering what this did: var PImage = require('../src/pureimage'); { // compositing tests // red onto white eq(PImage.compositePixel(0xFF0000FF, 0xFFFFFFFF), 0xFF0000FF); // blue onto white eq(PImage.compositePixel(0x00FF00FF, 0xFFFFFFFF), 0x00FF00FF); // red onto black eq(PImage.compositePixel(0xFF0000FF, 0x000000FF), 0xFF0000FF); // red 50% onto black eq(PImage.compositePixel(0xFF00007F, 0x000000FF), 0x7F0000FF); } function eq(a,b) { if(a != b) throw new Error(a.toString(16) + " is not equal to " + b.toString(16)); } function dumpBytes(img) { for(var i=0; i<10; i++) { console.log(i,img._buffer[i].toString(16)); } } It's clearly testing the compositePixel method - but I'm not quite sure what that method does - I also can't seem to find it in the library anywhere...unless it's referring to the composite method in the Bitmap class? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQ5ykqjgfgaK6tgxQHUmdW_6ITow7_Rks5s7OqkgaJpZM4QqsSi>.

[robertmain]

OK, no problem. In the mean time if you have a sec - #42 and #39 are done and ready for review/merge :)

[joshmarinacci]

Sorry, it's busy season as we prepare for the Mozilla All Hands next week. I just merged the pull requests. Thank you so much for all of your work.

…

-j

On Nov 29, 2017, at 12:47 PM, Robert Main ***@***.***> wrote: OK, no problem. In the mean time if you have a sec - #42 <#42> and #39 <#39> are done and ready for review/merge :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQ5ypHyFW5qe5-zISavRVAzhA5nWK54ks5s7cLYgaJpZM4QqsSi>.

[robertmain]

haha, no problem - i know how it is :)

not a problem - always happy to help out :D

[robertmain]

Oh by the way - I just looked at https://travis-ci.org/joshmarinacci/node-pureimage and it says it's not an active repo. Have you enabled travis because it looks like it's not running the build

[joshmarinacci]

I just made it active and triggered a build. https://travis-ci.org/joshmarinacci/node-pureimage <https://travis-ci.org/joshmarinacci/node-pureimage>

…

On Dec 6, 2017, at 9:27 AM, Robert Main ***@***.***> wrote: Oh by the way - I just looked at https://travis-ci.org/joshmarinacci/node-pureimage <https://travis-ci.org/joshmarinacci/node-pureimage> and it says it's not an active repo. Have you enabled travis because it looks like it's not running the build — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQ5yq20k87tO17VnLdPXnhqoy_1kxyfks5s9s5wgaJpZM4QqsSi>.

[robertmain]

Looks like you're missing the GITHUB_TOKEN environment var from Travis. Take a look at the pre-requisites here: #39 (comment) :)

Also - you might want to consider adding a link to http://joshmarinacci.github.io/node-pureimage at the top of your README for the documentation :)

Also - travis should let you rerun the failed build

[joshmarinacci]

I just set up the token and ran it again. Interestingly, this time two of the builds worked but one didn't. 1.1 and 1.3 worked but 1.2, the one with node 7, failed.

…

-j

On Dec 6, 2017, at 2:19 PM, Robert Main ***@***.***> wrote: Looks like you're missing the GITHUB_TOKEN environment var from Travis. Take a look at the pre-requisites here: #39 (comment) <#39 (comment)> :) Also - you might want to consider adding a link to http://joshmarinacci.github.io/node-pureimage at the top of your README for the documentation :) Also - travis should let you rerun the failed build — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAQ5ylqSAJWwMzKj2TBSImzNPeqyORqtks5s9xLZgaJpZM4QqsSi>.

[robertmain]

Odd - I took a look and it's mentioning that it couldn't push to gh-pages. It looks like it was saying that it couldn't push to Couldn't push the build to github.com/joshmarinacci/node-pureimage.git:gh-pages. I wonder if maybe the branch didn't exist at that point or something.

Try re-running the individual job again - if that still doesn't do it, you may have to raise an issue with Travis. Either way - looks like the docs are online! http://joshmarinacci.github.io/node-pureimage

[robertmain]

This looks like it might be related to travis-ci/travis-ci#8548

[robertmain]

@joshmarinacci

I emailed Travis support yesterday and they wondered if it might be because all 3 jobs are trying to do the deploy...can you try adding node: $TRAVIS_NODE_VERSION after line 18 of .travis.yml?

Like so:

language: node_js
node_js:
    - "node"
    - "7"
    - "8"
install: npm install
script:
  - npm run-script docs
deploy:
  overwrite: true
  provider: pages
  file_glob: true
  file: docs/*
  local_dir: docs
  skip_cleanup: true
  github_token: $GITHUB_TOKEN
  on:
    branch: master
    node: $TRAVIS_NODE_VERSION

This should restrict it so that only one build job actually deploys

[joshmarinacci]

it looks like all of this was done.