Read Exception in case of no character in the end of last row. about csvhelper

[JoshClose]

Can you paste in a small (couple of rows) example where the issue occurs?

[vk5880]

Hi, here is some additioinal information:

CsvHelper.1.8.0\lib\net40-client\CsvHelper.dll
Runtime version v4.0.30319
Version 1.8.0.22497

public class UserCsvModel
{
public int Id { get; set; }

    public string FirstName { get; set; }

    public string LastName { get; set; }

    public string Email { get; set; }
}

CsvFile contents inside []
[Id,FirstName,LastName,Email
1,v,k,[email protected],
2,v,k,[email protected],]

[JoshClose]

Did you use CsvWriter to create the contents of the file? How did the extra comma get on the end of the rows? What error are you seeing? What do you mean by manually modified and removed empty row at end?

[vk5880]

Sorry, my mistake, I incorrectly removed unnecessary columns in last example.
CsvFile contents inside []
[Id,FirstName,LastName,Email,Address
1,v,k,[email protected],Some address
2,v,k,[email protected],]

An error occurred trying to read a record of type 'UserCsvModel'.
Row: '4' (1-based)
Field Index: '0' (0-based)
Field Name: 'Id'
Field Value: ''

System.Exception: is not a valid value for Int32. ---> System.IndexOutOfRangeException: Index was outside the bounds of the array.
at System.ComponentModel.BaseNumberConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
--- End of inner exception stack trace ---
at System.ComponentModel.BaseNumberConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
at System.ComponentModel.TypeConverter.ConvertFromString(String text)
at lambda_method(Closure , ICsvReader )
at CsvHelper.CsvReader.d__0`1.MoveNext() in C:\Projects\CsvHelper\src\CsvHelper\CsvReader.cs:line 585

Just try to write a csv file, remove last \r\n characters and then try to read it. there should be no line end on last row.

[JoshClose]

I'm not able to reproduce it based on this information. I tried what you suggested and it's working for me, so I must be missing something.

Can you create a small example console app, zip it up, and email it to me?

[vk5880]

Paste this in CsvReaderTests.cs

           class UserCsvModel { 
        public int Id { get; set; } 
        public string FirstName { get; set; } 
        public string LastName { get; set; } 
        public string Email { get; set; }
        public string Address { get; set; }
    }

    [Fact]
    public void GetRecordsTest2()
    {
        var badCsv = @"Id,FirstName,LastName,Email,Address

1,v,k,[email protected],Some address
2,v,k,[email protected],1245";

        var stringReader = new StringReader(badCsv);
        var csvReader = new CsvReader(stringReader);            
        var records = csvReader.GetRecords<UserCsvModel>().ToList();

        Assert.Equal( 2, records.Count );

        for( var i = 1; i <= records.Count; i++ )
        {
            var record = records[i - 1] as UserCsvModel;
            Assert.Equal( i, record.Id );
        }
    }

[vk5880]

Have you succeeded with exception reproduction?

[JoshClose]

Sorry, been busy. I'm looking into it now.

[vk5880]

I think it is a bad practice to use the same class variable between method calls and support it state. It is better to use method argument in this case and take advantage of method scope. You have char c variable inside CsvParser and you probably forgot to clean it in the beginning of ReadLine method. This produce problem.

[JoshClose]

That's pretty much the case. I'll have a fix committed in a minute here and I'll link the change set.

[JoshClose]

Are you saying that the char c variable should be passed into Read()?

[JoshClose]

It's committed. Essentially a one line fix. ffbbada

[vk5880]

When we start to read next row do we really need to know what last character was? I may be wrong, but it seems to me that c can be local variable of ReadLine().
Thank you.

11.10.2012, 06:09, "Josh Close" [email protected]:

Are you saying that the char c variable should be passed into Read()?

—
Reply to this email directly or view it on GitHub.

Kind Regards, Костенко Владислав.

[JoshClose]

I will take a look.