Add support to automatically skip over blank rows about csvhelper

[AltruCoder]

@shwedberlin

csv.Configuration.ShouldSkipRecord = record => record.All(string.IsNullOrEmpty);

[JoshClose]

It should already be skipping blank lines. You can also turn on comments CsvReader.Configuration.AllowComments which will allow for lines that start with '#' to be skippped.

I can add in support for skipping lines that have only commas in them as a config setting. This will be done in the reader though, not the parser. It is a valid row, so the parser should still return an empty one.

[roryprimrose]

Hi Josh, sorry for the delay getting back to this one. Yes, a configuration option for this on the reader would be fine.

[JoshClose]

Ok. I will try and get to this soon. I've been working on WinRT support lately.

[JoshClose]

Got this done. 4129ff2

It will be a part of the 1.9 NuGet release.

[roryprimrose]

I've just upgrade my solution to use 1.9.0.34342 and I get the following failure in all my tests:

threw exception:
System.ArgumentNullException: Value cannot be null.
Parameter name: source
at System.Linq.Enumerable.All(IEnumerable1 source, Func2 predicate)
at CsvHelper.CsvReader.IsRecordEmpty(Boolean checkHasBeenRead) in c:\Projects\CsvHelper\src\CsvHelper\CsvReader.cs: line 768
at CsvHelper.CsvReader.Read() in c:\Projects\CsvHelper\src\CsvHelper\CsvReader.cs: line 158
at CsvHelper.CsvReader.d__0`1.MoveNext() in c:\Projects\CsvHelper\src\CsvHelper\CsvReader.cs: line 612

The bug appears to be that the IsRecordEmpty is called after the last record has been read at which point the currentRecord is null.

[JoshClose]

What version of .NET are you using?

[roryprimrose]

I’m using 4.0 client profile in the project that references CsvHelper.

From: Josh Close [mailto:[email protected]]
Sent: Tuesday, 23 October 2012 12:58 AM
To: JoshClose/CsvHelper
Cc: Rory Primrose
Subject: Re: [CsvHelper] Add support to automatically skip over blank rows (#53)

What version of .NET are you using?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-9664472.

[JoshClose]

I believe this should be fixed. Version 1.9.2 is on NuGet.

[arjendemooij]

For easy reference, this is the setting Josh implemented:

csv.Configuration.SkipEmptyRecords = true;

[shwedberlin]

Cannot find SkipEmptyRecords anymore.
Using version 12.x.
How can I skip rows with only separators now?