Comments (5)
It shouldn't be necessary to wrap them in elements. Could you provide an example where this happens?
from few.swift.
I am sure I am doing something stupid. Note that if I put the Views directly in the App component it works.
https://gist.github.com/mrjjwright/115abe0bf6e1ec9239a2
from few.swift.
Definitely a bug. We currently copy the layout properties from the component to the root element:
Few.swift/FewCore/Component.swift
Line 99 in e4d96d9
In this case that overwrites the assigned flex
. I imagine we should only copy those attributes which have been set. Or perhaps don't copy them at all?
from few.swift.
Or perhaps don't copy them at all?
This. Components should set their own styles. If they want an outside user to set something, they should take it as an arg.
from few.swift.
Yeah that copying code looked suspect to me as well. I tried commenting it out yesterday before I submitted the bug I thought but perhaps I didn't get it quite right.
from few.swift.
Related Issues (20)
- why both in the main thread HOT 3
- Is this dead? HOT 2
- Upgrade Swift version?
- .gitignore
- Render from the topmost dirty component downward HOT 1
- [RFC] Use ComponentSpec as api for defining components HOT 5
- Multi-line labels HOT 1
- Publicly get a layout Node for an element?
- Fix iOS TableView HOT 1
- How to have overlapping elements? HOT 5
- Installation documentation? HOT 3
- Use flexbox terminology HOT 1
- Input does not seem to follow "stretch" rule HOT 5
- Re-think in light of protocol extensions HOT 3
- Add instructions in README on how to edit demo HOT 4
- Add `didRealize` hook to Component HOT 1
- iOS: table view selection doesn't really work HOT 5
- AsyncDisplayKit HOT 2
- Carthage install issue on Xcode 7.1? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from few.swift.