Coder Social home page Coder Social logo

Nesting and flexbox about few.swift HOT 5 CLOSED

joshaber avatar joshaber commented on June 29, 2024
Nesting and flexbox

from few.swift.

Comments (5)

joshaber avatar joshaber commented on June 29, 2024

It shouldn't be necessary to wrap them in elements. Could you provide an example where this happens?

from few.swift.

mrjjwright avatar mrjjwright commented on June 29, 2024

I am sure I am doing something stupid. Note that if I put the Views directly in the App component it works.
https://gist.github.com/mrjjwright/115abe0bf6e1ec9239a2

from few.swift.

joshaber avatar joshaber commented on June 29, 2024

Definitely a bug. We currently copy the layout properties from the component to the root element:

newRoot.flex = flex

In this case that overwrites the assigned flex. I imagine we should only copy those attributes which have been set. Or perhaps don't copy them at all?

from few.swift.

joshaber avatar joshaber commented on June 29, 2024

Or perhaps don't copy them at all?

This. Components should set their own styles. If they want an outside user to set something, they should take it as an arg.

from few.swift.

mrjjwright avatar mrjjwright commented on June 29, 2024

Yeah that copying code looked suspect to me as well. I tried commenting it out yesterday before I submitted the bug I thought but perhaps I didn't get it quite right.

from few.swift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.