Coder Social home page Coder Social logo

useNativeClamp: false is broken about clamp.js HOT 3 OPEN

php4fan avatar php4fan commented on July 17, 2024
useNativeClamp: false is broken

from clamp.js.

Comments (3)

php4fan avatar php4fan commented on July 17, 2024

In getLastChild(elem):

            if (elem.lastChild.children && elem.lastChild.children.length > 0) {
                return getLastChild(Array.prototype.slice.call(elem.children).pop());
            }

Is this supposed to be:

            if (elem.lastChild && elem.lastChild.children && elem.lastChild.children.length > 0) {
                return getLastChild(Array.prototype.slice.call(elem.children).pop());
            }

or

            if (elem.children && elem.children.length > 0) {
                return getLastChild(Array.prototype.slice.call(elem.children).pop());
            }

?

Looks more likely to be the latter.

from clamp.js.

php4fan avatar php4fan commented on July 17, 2024

Also here:

            //This is the absolute last child, a text node, but something's wrong with it. Remove it and keep trying
            else if (!elem.lastChild || !elem.lastChild.nodeValue || elem.lastChild.nodeValue == '' || elem.lastChild.nodeValue == opt.truncationChar) {
                elem.lastChild.parentNode.removeChild(elem.lastChild); ///////////////// 1
                return getLastChild(element);                          ///////////////// 2
            }
  1. This throws error "cannot read property parentNode of null..." if elem.lastChild is null which is a possibility and does happen
  2. I'm pretty sure you mean elem, not element

from clamp.js.

php4fan avatar php4fan commented on July 17, 2024

Oh shit I'm wasting my time, this project hasn't been touched in 9 years.

from clamp.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.