Coder Social home page Coder Social logo

Update Module about pszoom HOT 6 CLOSED

josephmcevoy avatar josephmcevoy commented on June 19, 2024
Update Module

from pszoom.

Comments (6)

DamagedDingo avatar DamagedDingo commented on June 19, 2024

#14
These are the 2 new functions.

from pszoom.

JosephMcEvoy avatar JosephMcEvoy commented on June 19, 2024

#14 Correct me if I'm wrong -- List-ZoomRooms is the same cmdlet as Get-ZoomRooms, no? Looks like Zoom updated this API. You could open up a pull request to update the existing cmdlet. Do use PowerShell approved verbs. The cmdlets mentioned should all use Get.

Looks like you you're keeping with the style of the project (much appreciated). Something that is inconsistent across PSZoom's cmdlets is variable capitalization. Parameters should be capitalized while everything else should be camel case. Just being a bit nitpicky there but can be easier to read. This is a Powershell convention that you can read more about here. I am still to update this across all cmdlets...

What is the value of outputting the response as JSON (ConvertTo-Json -Depth 10)?

from pszoom.

DamagedDingo avatar DamagedDingo commented on June 19, 2024

They are giving different outputs and as i didn't know the use-case for the other I just left it.
I only output as JSON as the get-zoomrooms was outputting as JSON so i did it to keep it in line.

Should note that i would rather get a object out (which is what i do with my local copy).

from pszoom.

DamagedDingo avatar DamagedDingo commented on June 19, 2024

Oh as for using list thats what it was called in the API and you obviously already had 'Get-ZoomRooms'. Feel free to rename them as you see fit.

from pszoom.

DamagedDingo avatar DamagedDingo commented on June 19, 2024

Added last one for today and called it Get-DashboardZoomRooms. I removed the convertto-json so now it spits out a object. Will you update the others?
Also, I have never worked on someone elses github project before so if i mess anything up just let me know.

from pszoom.

DamagedDingo avatar DamagedDingo commented on June 19, 2024

What happened to Get-DashboardZoomRooms?
Was it removed on purpose?

from pszoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.