Coder Social home page Coder Social logo

Comments (10)

dulebap avatar dulebap commented on July 22, 2024 1

It works now. I've tried adding chcp 65001 in wrong place, by myself in that case.
Thanks for that fix.

from sudo-prompt.

jorangreef avatar jorangreef commented on July 22, 2024

Thanks @dulebap

Could you provide me with a bare minimum test script to reproduce?

Is your Windows setup custom configured (e.g. your shell encoding setup)?

While we are at it, would you mind checking if this is Windows only or can you find a way to reproduce this on other platforms?

from sudo-prompt.

dulebap avatar dulebap commented on July 22, 2024

I didn't changed anything in shell encoding setup. I have Windows 10 with display language English,but with Polish(Programmers) Keyboard layout. My Powershell and cmd has 852 (OEM - Latin II) code page set as default (as I said I didn't changed settings myself).
The bare minimum test script to reproduce is for example
var sudo = require('sudo-prompt');
sudo.exec("'C:\sampleFolderą\sampleProgram.exe'", function(error, stdout, stderr) {
console.log(error);
});
It is important to put some regional letter like "ą" in path.

I can try to reproduce this error on Mac later, or check how it works on Win 7 and Win 8. I let you know as soon as I manage to do so.

from sudo-prompt.

dulebap avatar dulebap commented on July 22, 2024

On Win 7 and Win 8 behaviour is the same as on Win 10. Tomorrow I should have possibility to test it on Mac. Have you managed to reproduce error on your side?

from sudo-prompt.

jorangreef avatar jorangreef commented on July 22, 2024

Thanks @dulebap

I can reproduce on my side on Windows 10 at least.

Can you create a plain .bat file with the following contents (or your actual command) and post the results?

C:\sampleFolderą\sampleProgram.exe

So above your .bat file contains only a single command (sampleProgram.exe). I think this is the bare minimum test case to reproduce.

from sudo-prompt.

dulebap avatar dulebap commented on July 22, 2024

Thanks @jorangreef

When encoding of command.bat was set to ansii I got:
C:\sampleFolder╣\sampleProgram.exe
The system cannot find the path specified.

When encoding was set to utf-8:
C:\sampleFolder─ů\sampleProgram.exe
The system cannot find the path specified.

When I set encoding in Notepad++ to OEM 852 the command runs fine. It means that probably when I tried to encode command generated by sudo-prompt to OEM 852 something went wrong?

from sudo-prompt.

jorangreef avatar jorangreef commented on July 22, 2024

Great, try the same .bat file but this time add this line at the top of the .bat file (as the first line):

chcp 65001

from sudo-prompt.

dulebap avatar dulebap commented on July 22, 2024

I've got:
C:\praca>chcp 65001
Active code page: 65001

C:\praca>\sampleFolderą\sampleProgram.exe 9002 "C:\sampleFolderą"
It looks like it works fine in that case (utf-8 encoding in bat file).

from sudo-prompt.

jorangreef avatar jorangreef commented on July 22, 2024

Thanks for your help with testing. I will have a fix soon.

from sudo-prompt.

jorangreef avatar jorangreef commented on July 22, 2024

Fixed by 6a0577a

Please try out version 8 and let me know how it goes!

from sudo-prompt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.