env: node\r: No such file or directory about sudo-prompt

[jviotti]

After some investigation, running the application that uses sudo-prompt directly (with node, electron, coffee) works fine, however the issue is reproducible when calling the script from an npm script.

[jorangreef]

Thanks @jviotti I will be away until next week and will look into it when I get back.

[jviotti]

@jorangreef I've found the root of the issue.

My application uses windosu to elevate permissions on Windows. This module exposes a sudo command, which get's installed in node_modules/.bin.

When calling a npm script, npm adds node_modules/.bin to the path, so when sudo-prompt executes sudo -n <command> it actually executes windosu's sudo instead of the system one. The latter happens to have \n\r line endings, ultimately throwing the initial error mentioned in the issue.

I'll mark windosu as an optional dependency in my application to avoid it being installed in other operating system than Windows, but I think we can improve sudo-prompt to avoid this issue by searching for the "system"'s sudo, which would make the module stronger and avoid someone else spending all day debugging the issue :)

I'm thinking we can change sudo -n to /usr/bin/sudo -n, which seems to be a quite standard location.

For the reason mentioned more portable alternatives like /usr/bin/env sudo or which sudo will not work, since they will evaluate to windosu's sudo.

What do you think?

Happy to send a pull request.

[jorangreef]

Merged. Thanks @jviotti.

[jviotti]

@jorangreef Awesome, thanks for the NPM publish!