How to setup comment strings with neovim treesitter and commentstring? about nvim-ts-context-commentstring

[JoosepAlviste]

Hey @eduardoarandah, just wanted to let you know that #3 has been implemented and PHP should work a bit better now.

However, I still didn't get the injected CSS and JS working because it doesn't seem like they even get injected.

Anyways, if you manage to inject those languages, then the current solution should work 😄 I just couldn't figure out how to get the injection working.

Other than that, let me know if there are any other problems with PHP.

[JoosepAlviste]

Hey! The tree that the PHP treesitter parser creates seems to be a bit weird and it doesn't seem to match the output in the treesitter playground.

For example, in this simple case, the playground shows the tags, but in reality, the HTML part is just text (everything up to <?php):

(I checked the current node under the cursor with :lua print(require'nvim-treesitter.ts_utils'.get_node_at_cursor(0):type()))

This means that there is no container node that can be used as a check for this plugin. The only nodes are text and program.

However, if I add a PHP end tag (?>), then there is a text_interpolation node:

text_interpolation seems like a good check for setting <!-- %s -->.

Everything inside text_interpolation is once again a text node. This means that any style or script tags cannot be detected 😕

Also, if the PHP tag is wrapped in an HTML tag, then the parser will break:

This is the best result I managed to get:

Screen.Recording.2021-03-27.at.22.51.38.mov

I used this config:

  php = {
    text_interpolation = '<!-- %s -->',
  },

And setlocal commentstring=//\ %s in after/ftplugin/php.vim

---

I'm hoping that once #3 is implemented, we could use language tree to improve this.