Comments (2)
You're patch is far too complex and contains much more than just the addition
of command line argument parsing. To have any hope of the maintainer committing
your changes you'd need to submit small single purpose patches. I count at
lease 5 in your patch (tidies like removing unused variables, breaking tests
into individual functions, extracting common code from tests that use
CombonationKeyTest, adding argument parsing, bulk code move of tests into
Tester.h). Also, always adopt the existing coding style in your patches.
For those interested I attach a patch the the bulk code move reversed so that
the OPs code changes are at least visible in a visual diff. The patch file is
still too complex to eyeball directly. I may come back later and further
subdivide this patch.
Original comment by [email protected]
on 4 Feb 2012 at 1:31
Attachments:
from smhasher.
Yeah, this change is too big to incorporate in one go. I might add pieces of it
in, so I'll leave this bug open for now.
Original comment by [email protected]
on 11 May 2012 at 6:24
from smhasher.
Related Issues (20)
- Patch for /trunk/MurmurHash3.cpp HOT 2
- Murmur3A on CentOS 6 x86_64 fails Window Tests HOT 1
- Minor changes to allow compiling MurmurHash3.cpp as C code. HOT 1
- SmHasher breaks without -fno-strict-aliasing
- could you add boost::hash to compare ? HOT 3
- MSVC2010 compilation. HOT 4
- City.cpp compilation warnings on Windows 64-bit target
- Probably bug in KeysetTest.cpp
- MurmurHash3_x64_128 reads past end of key buffer HOT 1
- [PATCH] Add missing `inline' keyword to FORCE_INLINE HOT 2
- Wrote a constexpr MurmurHash3 function
- SHA1 Sanity does not agree with Node.js SHA1. HOT 2
- MurmurHash3_x86_32 Algorithm Does Not match the one in Wikipedia HOT 3
- missing license
- Fixes to City.h to to allow inclusion in third-party sources HOT 1
- Make inline Functions static
- More hashes
- PMurHash.c on Solaris
- murmurhash3 128bit gives wrong result on big-endian platform HOT 1
- Improper handling of negative seeds HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smhasher.