Support 'include' directives about parse-git-config

[silverwind]

Examples (The values in the 2nd file are placeholder, not sure if git like them like that):

.gitconfig
.gitconfig.local

how about if we make that optional?

git parses included files by default, so I think this module should do. I'd see some value in having a option to disable parsing them, so a option to disable might make sense.

[jonschlinkert]

done, published and released as 2.0.

I attempted to trick the parser with conflicting options in the included file, but my testing showed that it parses conflicts exactly like git does. Nice work!

Thanks! I implemented the logic to follow the spec described in the link you provided, so that the config properties would be merged in the correct order. Glad it worked!

[jonschlinkert]

To clarify, you want the parsed object to include other the other git configs (which are specified using include)? I like the idea, how about if we make that optional?

edit: could you paste an example of the configs you use (obviously with fake information) so that I can use that for unit tests? thanks!

[jonschlinkert]

perfect! thanks!

edit:

git parses included files by default, so I think this module should do. I'd see some value in having a option to disable parsing them, so a option to disable might make sense.

True, but this module probably shouldn't follow the same rules, given that it's more likely that private information could be accidentally included and shared.

[silverwind]

Sure, I'm fine with a opt-in too.

[jonschlinkert]

I just pushed up a branch if you'd like to test it locally before I publish tomorrow.

edit: actually let me update a few things, then I'll ping you here again

[jonschlinkert]

k, I pushed up more changes. I'll add a changelog with more details, but in summary:

• adds promise support
• adds support for include
• renamed .keys method name to .expandKeys

[silverwind]

Looking good. During testing, I attempted to trick the parser with conflicting options in the included file, but my testing showed that it parses conflicts exactly like git does. Nice work!

[jonschlinkert]

Sorry, I completely forgot to come back and merge! I made the mistake of viewing this on my phone, then it disappeared from my new issues list, so I didn't see it when I logged on. publishing now!