review / plugin advice about gulp-rte

[sindresorhus]

1. Totally ok. It's different enough. The blacklist isn't meant to limit innovation, rather reduce blatant duplication and non-compliant plugins.

2. gulp-rte/index.js

   Line 14 in 660eab7

   cb(null, file);

   You should this.push(file), not add it in the callback. See the through2 docs.

OT to your question, but I personally find the :dirname:basename syntax a bit awkward. It's not apparently clear that they're two different vars. If I were to use it would have preferred:
{dirname}{basename}.

// @contra

[jonschlinkert]

thanks so much for the feedback!

The blacklist isn't meant to limit innovation

oh sure, I didn't view it as punitive. I think the guidelines and blacklist are good. I'm just not familiar enough with the conventions to have a reliable opinion.

You should this.push(file)

ahh yes of course... that makes sense, thank you

I personally find the :dirname:basename syntax a bit awkward

it can technically do either. I just didn't expose the option to change the syntax. I'll see if others like that syntax as well

thanks a lot for the feedback, really appreciate it!

[stephenlacy]

I also find the :dirname:basename odd compared to other plugins.

[jonschlinkert]

supposed to have slashes between path segments, e.g. :dirname/:basename.

to each his own I suppose (https://github.com/jonschlinkert/gulp-rte/blob/master/test/test.js#L162-L172). I'm curious what "odd compared to other plugins." means though, are there other plugins doing this or anything similar already? seems like I see it more than {a} (e.g. express, assemble, metalsmith come to mind).

thanks guys, I think you answered my questions!

[stephenlacy]

Odd referring to other gulp-plugins.