Comments (5)
Well spotted, looks like a bug.
That should probably check the sessionList
if the THIS_APP_SESSION
scope is provided and only add the tag if it doesn't exist in the list.
longer term, I'd like to change how the sessionList works and shift to how you described, so you have a session timestamp and it mirrors how the version scope check works.
Other work here is that toDo
doesn't work with timestamps yet, which would make it nice and symmetric with beenDone
from once.
@dernster I've just checked the code, we have a test around this. It's not obvious from the code (because as you've seen the implementation doesn't explicitly check THIS_APP_SESSION
), but actually because we only mark a tag as todo if its either it's never been done before, or if the scope is VERSION and we last saw the tag before the last update.
As I said this could use a refactor :) but it should be functional (check here: https://github.com/jonfinerty/Once/blob/master/once/src/test/java/jonathanfinerty/once/ToDoTests.java#L59 for validation)
from once.
@dernster I'll going to close this, if that's ok? I'll do the refactoring at some point, but outside of this issue as it's more an enhancement.
from once.
@jonfinerty You are right! Thanks for clarifying that :)
It's ok to close this.
I was reviewing your code since I was thinking about implementing this library for Swift. Our Android team use this Once component a lot and for iOS there was nothing like this.
Finally did it! You can check out Ecno (Once in reverse :)). In the README file we have a reference to your library so I hope it's all fine.
Thanks!
from once.
Amazing, thanks for the link, it's really cool someone is building upon something I built.
from once.
Related Issues (20)
- [Feature Request] Allow us to specify listeners for Once.initialise() completion HOT 3
- constant prefs filename HOT 1
- [Feature request] Allow us to retrieve the timestamp when an event was last marked done HOT 7
- How to use, Once times days, minutes HOT 4
- Got crash error on beenDone from users from google play console HOT 10
- crashes on startup in apk but is working on emulator HOT 9
- NumberFormatException: Invalid long HOT 3
- Get list of tasks that have been done
- I think there is a bug HOT 7
- ConcurrentModificationException HOT 4
- Provide a changelog HOT 2
- ConcurrentModificationException HOT 1
- Migrate away from JCenter HOT 1
- mavenCentral() support HOT 1
- To Do tasks fail to be persisted when force-stopping app HOT 1
- VERSION vs INSTALL tags backwards? HOT 1
- This project uses AndroidX dependencies, but the 'android.useAndroidX' property is not enabled
- Could not find com.jonathanfinerty.once:once:1.2.2 HOT 2
- Differences in publish artifact againt master branch
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from once.