Coder Social home page Coder Social logo

Comments (4)

JonasWanke avatar JonasWanke commented on June 22, 2024 1

I just found a workaround by avoiding the conflicting LayoutBuilder and am preparing a new release.

from timetable.

raLaaaa avatar raLaaaa commented on June 22, 2024

I was digging into to code of the timetable_header and adapted it slightly:

  @override
  Widget build(BuildContext context) {
    // Like [WeekYearRules.iso], but with a variable first day of week.
    final weekYearRule =
        WeekYearRules.forMinDaysInFirstWeek(4, controller.firstDayOfWeek);

    return Row(
      children: <Widget>[
            SizedBox(
            width: hourColumnWidth,
            height: context.timetableTheme?.totalDateIndicatorHeight ?? 72, // thats what i added
            child: ValueListenableBuilder<LocalDate>(
              valueListenable: controller.dateListenable,
              builder: (context, date, _) {
                final customHeader = leadingHeaderBuilder?.call(context, date);
                if (customHeader != null) {
                  return customHeader;
                }

                return Center(
                  child: WeekIndicator(weekYearRule.getWeekOfWeekYear(date)),
                );
              },
            ),
          ),
        Expanded(
          child: Column(
            mainAxisSize: MainAxisSize.min,
            children: <Widget>[
              SizedBox(
                height: context.timetableTheme?.totalDateIndicatorHeight ?? 72,
                child: MultiDateHeader(
                  controller: controller,
                  builder: dateHeaderBuilder,
                ),
              ),
              AllDayEvents<E>(
                controller: controller,
                onEventBackgroundTap: onEventBackgroundTap,
                allDayEventBuilder: allDayEventBuilder,
              ),
            ],
          ),
        ),
      ],
    );
  }

It results in:

image

Which is a little better but not perfect if you are using all day events. Since we know the size of the DateIndicator we can add that. How ever what we are missing is the height of the AllDayEvents. Thats why we have an offset here. I tried to fix that using IntrensicHeight widget how ever it is not allowed to be used inside a LayoutBuilder. Any ideas how we could add the missing height of the AllDayEvents?

Obviously if you have no AllDayEvents adding the height would work fine:

image

from timetable.

JonasWanke avatar JonasWanke commented on June 22, 2024

This is now fixed as part of v0.2.8.

from timetable.

raLaaaa avatar raLaaaa commented on June 22, 2024

Thanks for the quick help!

from timetable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.