Comments (2)
Hi, I assume you are talking about this line:
podman-gitlab-runner/prepare.sh
Line 66 in 3233a44
That seems fine to extend to other commands. The important part is that the container doesn't exit by itself, since the rest of the code assumes the container to run and performs podman exec
.
The default sleep behavior should probably be kept as is, if it is not overridden in custom_base.sh
. A PR is definitely welcome. I would appreciate it, if you could write a small example how to configure everything and place that inside custom_base.template.sh
.
from podman-gitlab-runner.
That's exactly it. Keeping the default too since there's no reason to break the current behavior and it's just fine for most use case. Will prepare a PR then :-).
from podman-gitlab-runner.
Related Issues (11)
- Support `DOCKER_AUTH_CONFIG`
- Podman in podman HOT 3
- Podman pulling image on every build despite edits to source HOT 3
- Only works with CUSTOM_ENV_CI_REGISTRY set
- local cache not restored HOT 2
- Improve install_command test HOT 1
- Change exit code HOT 1
- Rewrite code to be more idiomatic after Podman bugfix
- Add support for services via CI_JOB_SERVICES HOT 5
- Improve login to Gitlab Registry HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from podman-gitlab-runner.