Comments (4)
With regard to compressed pubkeys:
The pybitcointools bip32 libraries only use compressed pubkeys (in line with BIP 32 itself). I double checked by looking at the code (the privkeys are 33 bytes which is read as 'hex_compressed' or 'bin_compressed' by get_privkey_format(), and so encode_pubkey() produces a compressed pubkey output).
Maybe I totally missed the point, but isn't joinmarket only using the bip32 keys from pybitcointools?
from joinmarket.
With regard to protocol version, I had a think about it but didn't form a clear opinion. I think a !ver at start up is perfectly good for now, if we encounter some problem with that we could update it later.
from joinmarket.
Yep you are correct about joinmarket already using compressed keys.
from joinmarket.
Probably the best way to do this is for makers to announce !version along with their offers, and takers will send their version number along with their !fill command
from joinmarket.
Related Issues (20)
- Setup Docker
- Doublespending a sendpayment sweep, possible? HOT 7
- Install the script for me
- #joinmarket IRC tor relay HOT 1
- PGP pubkey key thread HOT 19
- No JSON object could be decoded HOT 5
- Failed to load wallet, error message: NameError("global name 'SegwitWallet' is not defined",) HOT 1
- twisted.internet.error.ReactorNotRunning: Can't stop reactor that isn't running. HOT 3
- Off-chain joinmarket fees
- Darkscience IRC network connection info HOT 1
- Agora throttling due to "Flooding" HOT 2
- wallet-tool.py "Method not found" HOT 1
- Support cookie authentication for local node HOT 2
- Problems and payment in cryptrocurrency
- Metal coin
- sendpayment.py -N 1 -m 4 wallet.jmdat 55555 bc1_address always fails. HOT 4
- pastebin Telegram bot
- Create landing page and documentation website HOT 2
- GUI does not start after installation
- Recover not scanning enough internal addresses? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joinmarket.