Coder Social home page Coder Social logo

Comments (4)

AdamISZ avatar AdamISZ commented on August 26, 2024

With regard to compressed pubkeys:

The pybitcointools bip32 libraries only use compressed pubkeys (in line with BIP 32 itself). I double checked by looking at the code (the privkeys are 33 bytes which is read as 'hex_compressed' or 'bin_compressed' by get_privkey_format(), and so encode_pubkey() produces a compressed pubkey output).

Maybe I totally missed the point, but isn't joinmarket only using the bip32 keys from pybitcointools?

from joinmarket.

AdamISZ avatar AdamISZ commented on August 26, 2024

With regard to protocol version, I had a think about it but didn't form a clear opinion. I think a !ver at start up is perfectly good for now, if we encounter some problem with that we could update it later.

from joinmarket.

chris-belcher avatar chris-belcher commented on August 26, 2024

Yep you are correct about joinmarket already using compressed keys.

from joinmarket.

chris-belcher avatar chris-belcher commented on August 26, 2024

Probably the best way to do this is for makers to announce !version along with their offers, and takers will send their version number along with their !fill command

from joinmarket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.