Coder Social home page Coder Social logo

Comments (3)

AdamISZ avatar AdamISZ commented on August 26, 2024

Problem occurs because of utxo_list being in unicode format at line 108: 46c8547#diff-fc8ffb45857c1b6539f3506c6c16a515R108

Easy fix is to call str(','.join(utxo_list)). (Although, a more generic way of addressing this problem is probably worth looking at).

Also on line 121, there is a typo: sig_list not sigs_list.

I just tried an example, it went through except it seems push_tx didn't complete (got complete raw tx but didn't see on network; will look into it).

from joinmarket.

AdamISZ avatar AdamISZ commented on August 26, 2024

I just tried an example, it went through except it seems push_tx didn't complete (got complete raw tx but didn't see on network; will look into it).

Forget that, the push command had been commented out. The complete transaction went through fine.

from joinmarket.

chris-belcher avatar chris-belcher commented on August 26, 2024

gaah!
I remember removing that str() for some silly reason. You can see it's still here. https://github.com/chris-belcher/joinmarket/blob/master/maker.py#L51

My bad. Well done for finding it.

from joinmarket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.