Comments (6)
I took a crack at this, but was stymied by my windows machine. My notes for anyone getting started if they like me were not familiar with the project:
- This is a mono repo with 5 sub projects living in
modules/node_modules/@colony
, this problem is inpurser-metamask
- The project uses flow, which takes a couple mins to set vscode up to use if not already
- Problem is that colony can't talk with metamask to do the login flow when metamask is being made available through this project https://github.com/MetaMask/metamask-mobile (rather than the browser extension, which works fine)
- As far as I can tell contact with meta-mask is attempted here
modules\node_modules\@colony\purser-metamask\index.js
- The test for that file is here
modules\tests\purser-metamask\open.test.js
- My plan was to build and run a local instance of metamask mobile which I could run the tests within, but this cannot (easily anyway) be done on a windows machine
from purser.
@BrighTide
Were you going to use the built in networking with MetaMask?
The process for connecting for MetaMask Extension go hand-in-hand with #289
MetaMask has the App and Browser Extension to take in to consideration when refactoring.
I'm also thinking that Google will be changing API regarding cryptocurrency wallets and browsers without announcing changes until it breaks and gets reported.
MetaMask (Android) is categorized as a Web Browser. The security available with MetaMask will not have had the testing as the main browsers and would be more susceptible to malware than the browsers already available and have been in development for much longer.
Some I can think of is hidden launch when browsers are set as default, or Cross Site Scripting and SSL...
A scenario below would not be ideal - as MetaMask will connect to a site that has failed verification.
I had an incident last year where Brave Browser on Android had Reward addresses hijacked for Twitter.
https://twitter.com/neobeum/status/1217029212973875200?s=20
from purser.
Unfortunately I didn't get deep enough into the issue to grok "Were you going to use the built in networking with MetaMask?" 😅. From what I could tell the extension made some stuff available in the global javascript context to the metamask website, and I assumed the MetaMask browser was attempting to do the same but couldn't for some reason. Plan was to run it all together with a debugger and see what fell off.
I can see the issues with the MetaMask, I'd hope they'd be actively pulling from a downstream major browser project rather than building their own. Power to them if they're that brave though 😄
@NeoBeum are you working on #289? I've seen you've been posting some stuff around it. Was thinking of picking it up myself
from purser.
Yeah - these two tasks are along the same line.
I don't have MetaMask on my development device - but I could probably unpack the APK and see what engine it is using... actually a scan one of the sandboxes might do it too.
I'm currently in the middle of creating a Local JoinColony node and then I'm going to start working on importing the libraries.
from purser.
Setup to test an issue like this https://github.com/BrighTide/purser/tree/69b9cfb685cc8c0dc3ad217ffb9c80653d61277f/metmask-mobile-test
from purser.
Closed by #296
from purser.
Related Issues (20)
- An in-range update of ethers is breaking the build 🚨 HOT 3
- An in-range update of eslint-config-airbnb-base is breaking the build 🚨 HOT 1
- An in-range update of @ledgerhq/hw-app-eth is breaking the build 🚨 HOT 2
- An in-range update of @ledgerhq/hw-transport-u2f is breaking the build 🚨 HOT 1
- An in-range update of @ledgerhq/hw-app-eth is breaking the build 🚨 HOT 1
- An in-range update of babel7 is breaking the build 🚨 HOT 26
- An in-range update of chokidar is breaking the build 🚨 HOT 6
- An in-range update of @ledgerhq/hw-app-eth is breaking the build 🚨 HOT 11
- Fix Ledger and Trezor Hardware support
- Move this project to TypeScript HOT 4
- Add `WalletConnect` support HOT 3
- Add `Fortmatic` support HOT 1
- Add `Unilogin` support
- Add `Authereum` support HOT 2
- Add `Portis` support
- Add `Tor.us` support
- An in-range update of regenerator-runtime is breaking the build 🚨 HOT 1
- Common wallet interface fields are not very common HOT 1
- Unable to log in with MetaMask wallet HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from purser.