Private variable - leading underscore about angular-styleguide

[froodley]

The main VS Code plugin (?) for autogenerating getters and setters
https://marketplace.visualstudio.com/items?itemName=DSKWRK.vscode-generate-getter-setter&_sm_au_=iVV7W3sWs2200Q56

has this behavior:

If a private variable is named with a leading underscore, the getter and setter will be generated in the same way as described in the TS documentation, above.

If it does not have a leading underscore, the getter and setter will be generated with a leading $, and the internal variable will remain unchanged. This does not seem preferable to the internal leading underscore:

public get $var1(): string {
	return this.var1;
}

[froodley]

Has there been any update here?

[froodley]

Still looking for feedback on this

[alterfo]

I agree

[froodley]

Ref:

angular/angular.io#1108 (comment)

[pburkindine]

An important concern for us here is that the recommended behavior be lintable.

tslint-consistent-codestyle.naming-convention e.g. allows us to define a pattern for all private fields, but not a rule that would only apply to internal fields mapped by public properties.

So e.g. 'Consider using _ only for internal fields mapped by properties' would not be lintable.

[pburkindine]

Ref:

angular/angular#26393