Coder Social home page Coder Social logo

Comments (7)

JohnnyMorganz avatar JohnnyMorganz commented on June 11, 2024 1

Yes, I think it is valid still. I will restructure your feature request to "Use closest configuration to file"

from stylua.

JohnnyMorganz avatar JohnnyMorganz commented on June 11, 2024

we stop at first .stylelua file, somehow it does not stop and merges

this sounds incorrect to me, we don't merge two stylua files together. That sounds like the underlying issue here, rather than adding something else to stop at git roots.

from stylua.

gabyx avatar gabyx commented on June 11, 2024

Ah maybe you start the discovery of the style file from the current working directory, which IMO is wrong. Could that be the issue here?

from stylua.

JohnnyMorganz avatar JohnnyMorganz commented on June 11, 2024

Ah yes, that seems more like it. Indeed, we just use the config found at the cwd across all the code.

I have been thinking about this though - maybe we should be using the closest configuration to the file.

I do question why you are running stylua on a sub module though. I typically think sub modules are vendored code, hence should be ignored by style tools, but maybe that is not the case for you.

from stylua.

gabyx avatar gabyx commented on June 11, 2024

from stylua.

gabyx avatar gabyx commented on June 11, 2024

Ehm, hehe πŸ˜‰ yes thats true, bitbthe astronvim distribution works differently :). But tou are right I meant I always executed the format with the cwd in the submodule and since it has a config file that one should be found, strange, I check again in a few days.

Anyway, all format tools actually do this as far as I know from clang-format - start from the file. Please check again, now a bit unsure.

from stylua.

gabyx avatar gabyx commented on June 11, 2024

@JohnnyMorganz : Would improve tooling much, since it will pick up the closest .stylelua.toml file and make an astronvim user install much nicer! Looking forward to this. BR

from stylua.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.