De-couple the output about query-monitor

[johnbillion]

@lkraav See https://github.com/johnbillion/query-monitor/tree/json-output. In this branch, QM outputs a qm_json object too. It can, for example, be queried in your browser console with something like qm_json.db_queries.times['get_option()'].calls.

See the commit at cd1bd85 for which files you'll want to start hacking for your own needs.

[lkraav]

Reactions ^^^^

[heydonovan]

Yes! I'd love to see this log to syslog/error_log, or even provide JSON output for automation cases. Time and time again, I'll see themes that break the HTML output, and so I've got to manually view the output through raw HTML (which isn't very fun at all).

[johnbillion]

Closing this as fixed. I'm going to open up follow-up issues for further work.

[johnbillion]

Query Monitor 2.6 has greatly increased abstraction. Output is now handled in separate classes from the data collection, which goes a long way to facilitating other methods of output as described above.

More to come, but this is the majority of it.

[johnbillion]

Marking this as complete. The data collection is sufficiently abstracted from the output now. I'm going to work on a persistent log at some point, but it's not too high on my priority list currently.

[FabianSperrle]

Any news on the persistent logging? Do I have to get my hands dirty or have you made progress already? 😄

[johnbillion]

@FabianSperrle It's in the pipeline, but no, there's nothing ready yet.

If you want to get your hands a little dirty, there's a very rough and ready implementation in the logger branch which I knocked up ages ago when I needed it. It logs some output to error_log(). Not ideal but handy if you really need it. Also take note of this.

[lkraav]

I'm also looking for JSON format output, to automagically send a subset of performance data to outside analytics tools - let's say Google Analytics events for the simplest example.

It doesn't look like this moved a whole lot, so wondering what could be the next step here? How massive is the workload here I wonder? If there was a $$$ bounty on it, how much would someone take this on for?

[johnbillion]

@lkraav This would be relatively simple to implement, the only problem would be that QM still logs some large objects in three places (hooks, JS & CSS, and backtraces).

I'll push some code later this evening that demonstrates how to write an output dispatcher without having to handle every different data collector in QM.

[lkraav]

@johnbillion the branch has an initial state of outputting var qm_json = ; syntax error, which looks like $out isn't getting populated correctly for some reason. Is this normal or?

[johnbillion]

Not quite sure what's going on there. Try reloading the page and the qm_json variable should be correctly populated.

[lkraav]

Not quite sure what's going on there. Try reloading the page and the qm_json variable should be correctly populated.

@johnbillion I'm not able to get the object to show up. Perhaps backtracing the output is the next step, but this isn't showing anything meaningful.

1 .../wp-includes/plugin.php:525QM_Dispatcher_JSON->dispatch(#1)
2 .../wp-includes/load.php:638do_action(tag)
3 PHP internal callshutdown_action_hook()

→ Called from .../query-monitor.git/dispatchers/JSON.php:46 [QM_Dispatcher_JSON->dispatch()]