Coder Social home page Coder Social logo

Comments (5)

joeldbirch avatar joeldbirch commented on June 26, 2024

I think that as soon as you start altering any third-party core code that's a sign that you're doing it wrong. This is really just a CSS issue that you should beg or employ someone to help you with.

Why not just have all top-level items have arrows-down when they have subs and all nested items have arrows-right, as per the default Superfish CSS, and just hide the top-level arrows of the admin bar by targetting them with a class that only the admin bar has? Such as:

.admin-bar > li > a > .sf-sub-indicator {
    display: none;
}

From your description, it seems like this is all you need. I may have misunderstood though.

from superfish.

PRISMAY avatar PRISMAY commented on June 26, 2024

Hi,
Yes, I have our CSS folks looking at it but I needed to get it working for now.

The “why not” question is not up to me. I just do what the “designers” want and they want it like I described and it’s a fight I won’t win. ;)

I think I tried what you suggested already but it didn’t work. I’ll report back after I had a chance to talk to our CSS folks. Thanks much.

Arthur

From: joeldbirch [mailto:[email protected]]
Sent: Thursday, March 14, 2013 8:54 AM
To: joeldbirch/superfish
Cc: Arthur Yousif
Subject: Re: [superfish] Different Arrows For Multiple Menus On Same Page (#23)

I think that as soon as you start altering any third-party core code that's a sign that you're doing it wrong. This is really just a CSS issue that you should beg or employ someone to help you with.

Why not just have all top-level items have arrows-down when they have subs and all nested items have arrows-right, as per the default Superfish CSS, and just hide the top-level arrows of the admin bar by targetting them with a class that only the admin bar has? Such as:

.admin-bar > li > a > .sf-sub-indicator {

display: none;

}

From your description, it seems like this is all you need. I may have misunderstood though.


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-14903135.

from superfish.

joeldbirch avatar joeldbirch commented on June 26, 2024

I thought my "why not" suggestion did match how your designers want it. I guess I misunderstood. Either way, it's definitely a CSS issue. Hope you get it done.

from superfish.

PRISMAY avatar PRISMAY commented on June 26, 2024

Actually, I misunderstood. You’re right, your “why not” suggestion would do what we want. Thank you.

Arthur

From: joeldbirch [mailto:[email protected]]
Sent: Thursday, March 14, 2013 9:05 AM
To: joeldbirch/superfish
Cc: Arthur Yousif
Subject: Re: [superfish] Different Arrows For Multiple Menus On Same Page (#23)

I thought my "why not" suggestion did match how your designers want it. I guess I misunderstood. Either way, it's definitely a CSS issue. Hope you get it done.


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-14903743.

from superfish.

PRISMAY avatar PRISMAY commented on June 26, 2024

Joel,
Your suggestion worked great. :) Thank you. And all before our CSS team woke up.

from superfish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.