MacOs Sierra "npm run build.dev" failure caused by webpack about angular-electron

[joaogarin]

Hello Can you check this issue, someone had something simillar but they where able to get it working? I cant seem to reproduce this one :/ #38

[joaogarin]

Hello,

Where you able to find something? There is also this issue here in the angular-cli which points to something simillar angular/angular-cli#1922

I just ran a clean

rm -rf node_modules && npm install && npm run build

And I got no errors.

Best regards
Joao Garin

[nagarsuresh]

i was facing the same issue and I am very new to webpack+electon etc, i did one change and it got build and can see the app also require('os').platform() is printing darwin in console.
all i did was in the webpack.config.json
replace the line
config.target = webpackTargetElectronRenderer(config);
with
config.target = 'electron-renderer';
and commented webpackTargetElectronRenderer in the webpack.config.json
coz in the https://github.com/chentsulin/webpack-target-electron-renderer its given something like that.
is it ok to do that ?

[joaogarin]

Yes that looks correct looking at https://github.com/chentsulin/webpack-target-electron-renderer#migrate-to-webpack-2-or-webpack-1--11215

If you want to make a pull request for that it would be awesome. If not I will included as soon as I get some time.

Thanks for the info!

[nagarsuresh]

Thanks @joaogarin ,
I will make a pull request for this.

[nagarsuresh]

@joaogarin i am not able to create remote branch, could you add me as collaborator to the project.

[joaogarin]

You would have to fork the repository, create your own branch in your own repository (not in this one) and then issue a pull request.

You can read more about it here : https://help.github.com/articles/creating-a-pull-request/

[nagarsuresh]

Thanks @joaogarin for pointing in right direction, created a pull request.