No thumbnail rendered, memory error in octoprint.log about octoprint-prusaslicerthumbnails

[jneilliii]

I probably need to come up with another parsing routine since it currently uses a regular expression match against the whole file contents. That's really overkill since the thumbnails are currently stored right at the very beginning of the file.

[erezge]

This has to do with a change I requested in order to support also thumbnails in Cura which end with CRLF instead of LF like PrusaSlicer does.
After looking for a possible solution to remove the need for the replace I came up with this solution:
Replace :
regex = r"(?:^; thumbnail begin \d+x\d+ \d+)(?:\n|\r\n?)((?:.+(?:\n|\r\n?))+)(?:^; thumbnail end)"
With :
regex = r"(?:^; thumbnail begin \d+x\d+ \d+)(?:\n|\r\n?)((?:[^\n\r]+(?:\n|\r\n?))+)(?:^; thumbnail end)"

This allows supporting both LF and CRLF without the replace statement. From my tests the solution seems to produce the exact same outputs.

[jneilliii]

What version of octoprint?

[ochm]

What version of octoprint?

OctoPrint 1.4.0 running on OctoPi 0.17.0

[jneilliii]

I think I may have just fixed this issue with the latest release. Please check it out and let me know, version 0..1.1. You may have to force a check in the bottom of Software Update in the Advanced section at the bottom..

[ochm]

Perfect! 0.1.1 renders the big gcode file without issue. Thank you!