Coder Social home page Coder Social logo

Comments (6)

cyrille-leclerc avatar cyrille-leclerc commented on September 4, 2024

Hello @BriacRONDI , I just discover your message, I had a notification issue.

Could you capture more details? I suspect that InfluxMetric.valueAsStr() could be more strict about float / decimal conversions. I see a risk with the locale of the JVM where valueAsStr() could emit a "," instead of a ".".

from jmxtrans-agent.

cyrille-leclerc avatar cyrille-leclerc commented on September 4, 2024

I have identified a potential issue: big float values in java get formatted with an exponent

float value = 123_456_789.012_345;
System.out.println("value: " + value);

will return 1.23456789012345E8

See #95

from jmxtrans-agent.

cyrille-leclerc avatar cyrille-leclerc commented on September 4, 2024

@kerlandsson can I get your feedback on this issue and on my PR #95 ? I suspect that we should be more strict than invoking Float.toString() to format floats.

I found in the official java client https://github.com/influxdata/influxdb-java/blob/influxdb-java-2.5/src/main/java/org/influxdb/dto/Point.java#L321

NumberFormat numberFormat = NumberFormat.getInstance(Locale.ENGLISH);
numberFormat.setMaximumFractionDigits(MAX_FRACTION_DIGITS);
numberFormat.setGroupingUsed(false);
numberFormat.setMinimumFractionDigits(1);

from jmxtrans-agent.

GitImpulseIt avatar GitImpulseIt commented on September 4, 2024

Thank you for working on this issue. I will test your PR as soon as possible and will give you a feedback.

from jmxtrans-agent.

cyrille-leclerc avatar cyrille-leclerc commented on September 4, 2024

According to https://github.com/influxdata/influxdb-java/blob/influxdb-java-2.5/src/main/java/org/influxdb/dto/Point.java#L321

The expected string for 123_456_789.012_345 is 123456789.012345 and is NOT 1.23456789012345E8 as we generate today.

from jmxtrans-agent.

cyrille-leclerc avatar cyrille-leclerc commented on September 4, 2024

Fix should be ready at #95

from jmxtrans-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.