Dynamic reload of configuration about jmxtrans-agent

[cyrille-leclerc]

Good idea, we could look at https://github.com/jmxtrans/embedded-jmxtrans/blob/696645d866ff681be52d083174e587fca73263b5/src/main/java/org/jmxtrans/embedded/spring/EmbeddedJmxTransFactory.java#L93

[kerlandsson]

@cyrille-leclerc I noticed that you did some refactoring on this. In my PR I checked the actual contents of the document to see if configuration is changed, supporting files exposed via HTTP as well. Now the modified date is checked instead and configuration exposed via HTTP is never reloaded (if I understand correctly). What were the reasons for this change?

[cyrille-leclerc]

Hello @kerlandsson,

I wanted to match Spring Framework's Resource API and its [lastModified()][http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/core/io/Resource.html#lastModified--] method.

I did not catch you were using this feature with HTTP. I'll add support ASAP for HTTP LastModified.

Would that cover your need?

Cyrille

[kerlandsson]

@cyrille-leclerc Ok, I understand. We are not actually using it so nothing is broken for us. I was mostly curious why the change was made.

[cyrille-leclerc]

Thanks @kerlandsson, I forgot to mention that I feel it's good to process to simple touch as a request to reload the configuration.

[cyrille-leclerc]

@kerlandsson please check with 1.2.2 to see if we can close this issue.