Comments (2)
I think the reason has to do with Algorithm.php 87:
$successors = $this->computeAdjacentNodes($currentNode, $goal);
Currently computeAdjacentNodes sets parents for all adjacent nodes, but we have not done the checks to see if we need to revisit the successor, until later:
if ($successor->getG() >= $successorInOpenList->getG()) {
I think these checks should be done first, and then set parents only if successor passes this check.
I totally could be wrong. But I think wiki agrees with this comment:
http://en.wikipedia.org/wiki/A*_search_algorithm#Pseudocode
from php-a-star.
Thank you very much for submitting this issue.
The solution you submitted on #3 worked for that scenario, but it broke some other tests unfortunately.
You are right when you say that we need to delay the setting of the parents after the checks, but the problem with your solution in #3 is that you also delayed the setting of the G and H values, which made the algorithm fail in other scenarios.
I've deployed a fix, which is available in v1.1.1.
from php-a-star.
Related Issues (13)
- Performance: allocating new nodes HOT 7
- Create a benchmark utility HOT 1
- Maybe consider generalizing the algorithm to allow for BFS, UCS, DFS, etc HOT 2
- Measure memory usage in the benchmark
- Measure number of nodes expanded in the benchmark
- Run static analysis tools HOT 1
- Exclude unnecessary files when composer is run with --prefer-dist
- Remove unneeded methods in the Node interface
- Improve the NodeList's efficiency HOT 4
- Scrutinizer support
- Enforce the coding standards via Travis-CI HOT 1
- Ease the library usage HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-a-star.