Coder Social home page Coder Social logo

Comments (7)

liyuan1125 avatar liyuan1125 commented on June 15, 2024 1

I'll add better error messages for this.

Thank you very much!

from goverter.

jmattheis avatar jmattheis commented on June 15, 2024

Please add the models ent.Account and pb.QueryResponse_Account to this issue.

from goverter.

liyuan1125 avatar liyuan1125 commented on June 15, 2024

Please add the models ent.Account and pb.QueryResponse_Account to this issue.

type Account struct {
	ID uint64 `json:"id,omitempty"`
}

type QueryResponse_Account struct {
	ID                   uint64   `protobuf:"varint,1,opt,name=id,proto3" json:"id"`
	XXX_NoUnkeyedLiteral struct{} `json:"-"`
	XXX_unrecognized     []byte   `json:"-"`
	XXX_sizecache        int32    `json:"-"`
}

from goverter.

jmattheis avatar jmattheis commented on June 15, 2024

Cannot reproduce:

$ cat input.go
package test

// goverter:converter
type Converter interface {
        // goverter:ignore XXX_NoUnkeyedLiteral XXX_unrecognized XXX_sizecache
        Convert(source Account) QueryResponse_Account
}

type Account struct {
        ID uint64 `json:"id,omitempty"`
}

type QueryResponse_Account struct {
        ID                   uint64   `protobuf:"varint,1,opt,name=id,proto3" json:"id"`
        XXX_NoUnkeyedLiteral struct{} `json:"-"`
        XXX_unrecognized     []byte   `json:"-"`
        XXX_sizecache        int32    `json:"-"`
}
$ go run github.com/jmattheis/goverter/cmd/goverter test
$ cat generated/generated.go
// Code generated by github.com/jmattheis/goverter, DO NOT EDIT.

package generated

import test "test"

type ConverterImpl struct{}

func (c *ConverterImpl) Convert(source test.Account) test.QueryResponse_Account {
        var testQueryResponse_Account test.QueryResponse_Account
        testQueryResponse_Account.ID = source.ID
        return testQueryResponse_Account
}

from goverter.

liyuan1125 avatar liyuan1125 commented on June 15, 2024

Cannot reproduce:

$ cat input.go
package test

// goverter:converter
type Converter interface {
        // goverter:ignore XXX_NoUnkeyedLiteral XXX_unrecognized XXX_sizecache
        Convert(source Account) QueryResponse_Account
}

type Account struct {
        ID uint64 `json:"id,omitempty"`
}

type QueryResponse_Account struct {
        ID                   uint64   `protobuf:"varint,1,opt,name=id,proto3" json:"id"`
        XXX_NoUnkeyedLiteral struct{} `json:"-"`
        XXX_unrecognized     []byte   `json:"-"`
        XXX_sizecache        int32    `json:"-"`
}
$ go run github.com/jmattheis/goverter/cmd/goverter test
$ cat generated/generated.go
// Code generated by github.com/jmattheis/goverter, DO NOT EDIT.

package generated

import test "test"

type ConverterImpl struct{}

func (c *ConverterImpl) Convert(source test.Account) test.QueryResponse_Account {
        var testQueryResponse_Account test.QueryResponse_Account
        testQueryResponse_Account.ID = source.ID
        return testQueryResponse_Account
}

Hi,
Thank you very much for your reply, I have created a repository here, you can take a look;
https://github.com/leewithyuan/app1

from goverter.

jmattheis avatar jmattheis commented on June 15, 2024

You cannot use ignore on array, define it directly on the struct convert method

// goverter:converter
type Converter interface {
	// goverter:ignore XXX_NoUnkeyedLiteral
	// goverter:ignore XXX_unrecognized
	// goverter:ignore XXX_sizecache
	Convert(source models.Account) pb.Account
	ConvertArray(source []models.Account) []pb.Account
}

from goverter.

jmattheis avatar jmattheis commented on June 15, 2024

I'll add better error messages for this.

from goverter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.