Comments (6)
@Tapchicoma you want to take a crack at this one? Can you add some simple Junit tests that cover this too for us?
from ktlint-gradle.
@JLLeitschuh yeah, I will take a look.
In version 0.10.0
ktlint introduced multiple reporters support. I think this is the cause.
from ktlint-gradle.
@Tapchicoma Hijacking this issue for a second, come chat with me either in the gitter chat or find me in the Kotlin Slack (slack is better for me).
from ktlint-gradle.
Quick and dirty fix:
private fun isReportAvailable(version: String, availableSinceVersion: String): Boolean {
val versionsNumbers = version.split('.')
val reporterVersionNumbers = availableSinceVersion.split('.')
return versionsNumbers[0].toInt() >= reporterVersionNumbers[0].toInt() &&
versionsNumbers[1].toInt() >= reporterVersionNumbers[1].toInt() &&
versionsNumbers[2].toInt() >= reporterVersionNumbers[2].toInt()
}
from ktlint-gradle.
We may want to consider doing our parsing with this library:
https://github.com/zafarkhaja/jsemver.
Might be overkill though.
from ktlint-gradle.
@leinardi little improve your fix, but solution is right.
from ktlint-gradle.
Related Issues (20)
- Ktlint Fails to Detect Formatting Issues in Nested Modules HOT 7
- Failing Builds Automatically HOT 1
- Same Issue HOT 6
- Cannot apply to buildSrc HOT 4
- Using this plugin with the official IntelliJ IDE plugin HOT 4
- K2 issue: A failure occurred while executing worker.KtLintWorkAction FILE HOT 2
- Ktlint checks generated source since 12.1.0 HOT 6
- Task KtlintMainSourceSetCheck failed HOT 2
- Task :runKtlintCheckOverMainSourceSet FAILED HOT 3
- import checks HOT 1
- Caches work incorrectly: additionalEditorconfig should be @Input instead of @Internal HOT 3
- Filter to exclude a generated dir is not working in version 12.1.0 HOT 3
- ktlint pre-commit hook HOT 1
- Using ktlint-gradle with ktlint-intellij-plugin and baseline file
- Is there way to know which (maximum) ktlint versions are supported? HOT 2
- Version number in documentation
- deprecate old android flag
- unknown ktlint version HOT 2
- hxgc
- Deprecation warning with `ActionUpdateThread` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ktlint-gradle.