v3 is broken after key is not given anymore in params about redmine_airbrake

[jkraemer]

Thanks for the idea with the filter, that's what I implemented now as the default way to configure this. notice[:redmine] didn't work though, I chose notice[:context][:redmine_config].

Greetings from the Philippines :)

[jkraemer]

Hi :)

I think the proper solution would be to handle this case and grab the serialized data (aka project key) from the Authorization header if no key param is present. I'm not sure about potential length limits in http headers but if we're lucky we can continue abusing this value as we did before.

I can have a look at that but almost certainly not before Christmas...

Cheers!

[jkraemer]

On a sidenote - why you cannot simply use a slightly older version of airbrake-ruby? :)

[aiomaster]

Yeah, just use an older version is an option, but I am not a friend of this, cause you shift the problem to the future when you have to upgrade, cause some other dependencies forces you.

I just don't understand why there is this abuse of the project_key and maybe there could be a better option to provide additional information to the request.
If it could be part of the json request body there would be no potential length limits like in HTTP headers and it could get parsed with the rest of the body, so we don't need to mess around with CGI.escape and that stuff. The downside is, that a change in airbrake-ruby is required and we need a custom key that is not used in the rest of the airbrake json schema. Maybe the key could be configurable.

[aiomaster]

Hi @jkraemer,
maybe it could be a lot easier to include the additional redmine parameters in the json body of the notice.
We could for example do the following in our airbrake initializer:

Airbrake.add_filter do |notice|
  notice[:redmine] = {
    tracker: 'Exception',
    api_key: 'foo',
    project: 'bar',
    assigned_to: 'developer'
  }
end

Then we have to extract the config information after parsing the request body. This seems like a clean solution to me. What do you think? Should I make a PR for this?