Coder Social home page Coder Social logo

Comments (8)

abhinavs1920 avatar abhinavs1920 commented on June 4, 2024 1

I would like to work on this issue. Thank You!!!

from jitsi-meet.

jlemangarin avatar jlemangarin commented on June 4, 2024

@damencho What do you think ? Can we start to work on it ?

from jitsi-meet.

damencho avatar damencho commented on June 4, 2024

How will you authenticate the http requests that are executed in the addPeopleDialog?

from jitsi-meet.

raphaelbadawi avatar raphaelbadawi commented on June 4, 2024

Well right now in my current build I've added "credentials: "include"" in the fetch calls coming from searchDirectory and invitePeopleAndChatRooms. So cookies are included in the request and so my directory service can work things out.

This is not an ideal solution.

I guess it would be better to be able to add custom keys and values in the query string, via the config.js, so whatever the directory service is expecting it could just be added to the query string by tweaking config.js.

from jitsi-meet.

damencho avatar damencho commented on June 4, 2024

Adding something in config.js is not an option, as it is publicly accessible. You need something per user as the jwt.

from jitsi-meet.

raphaelbadawi avatar raphaelbadawi commented on June 4, 2024

Even if the something actually refers to a localStorage key for example?

from jitsi-meet.

damencho avatar damencho commented on June 4, 2024

Yeah, maybe read a value from there and add it as Authorization to the request, that will work.
If you are preparing a PR, make sure this is turned off by default and current behaviour is not changed.

from jitsi-meet.

raphaelbadawi avatar raphaelbadawi commented on June 4, 2024

Okay I will base the PR on those specs ;-) Thanks!

from jitsi-meet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.