Comments (8)
I would like to work on this issue. Thank You!!!
from jitsi-meet.
@damencho What do you think ? Can we start to work on it ?
from jitsi-meet.
How will you authenticate the http requests that are executed in the addPeopleDialog?
from jitsi-meet.
Well right now in my current build I've added "credentials: "include"" in the fetch calls coming from searchDirectory and invitePeopleAndChatRooms. So cookies are included in the request and so my directory service can work things out.
This is not an ideal solution.
I guess it would be better to be able to add custom keys and values in the query string, via the config.js, so whatever the directory service is expecting it could just be added to the query string by tweaking config.js.
from jitsi-meet.
Adding something in config.js is not an option, as it is publicly accessible. You need something per user as the jwt.
from jitsi-meet.
Even if the something actually refers to a localStorage key for example?
from jitsi-meet.
Yeah, maybe read a value from there and add it as Authorization to the request, that will work.
If you are preparing a PR, make sure this is turned off by default and current behaviour is not changed.
from jitsi-meet.
Okay I will base the PR on those specs ;-) Thanks!
from jitsi-meet.
Related Issues (20)
- Enhancement the new messages for local participant
- Regression: keyboard navigation in Popovers HOT 4
- User can never join meeting due to membersOnly HOT 3
- Displaying emoji descriptions when hovering in smileys panel HOT 2
- Missing translation function
- Error message not readable
- Build a new SmileysPanel(emoji picker) HOT 1
- Adding single answer poll type HOT 1
- Render Emoji in chat input messagebox HOT 1
- GIF rendering issue when a new participant joins the meeting HOT 2
- Fixes RaiseHand label ParticipantPane issue HOT 5
- Recording could be auto-saved when meeting disconnects HOT 2
- Not join room after upgrade HOT 7
- [Android] JitsiMeetView mic got muted when app is in background or turn off screen. HOT 5
- Redirection if JWT is invalid or expired HOT 7
- Jitisi audio only mode, disables my own camera HOT 1
- Password Prompt in Safari HOT 11
- [React native SDK] [iOS] - Screen share cannot working HOT 3
- ECHO while calling from android to ios and both are in speaker echo voice comes.. how to solve this issues? HOT 3
- React-Native v2.0.2 Video Sharing Issue HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jitsi-meet.