Coder Social home page Coder Social logo

Comments (6)

bgrozev avatar bgrozev commented on June 29, 2024

Makes sense. I think there's two parts to the solution:

  1. Adding a Colibri2Error with a new UNKNOWN_ENDPOINT Reason to error responses from the bridge.
  2. Recognizing these errors in jicofo and handling them differently (only re-invite that single endpoint)

from jicofo.

mykhailo-ua avatar mykhailo-ua commented on June 29, 2024

Makes sense. I think there's two parts to the solution:

  1. Adding a Colibri2Error with a new UNKNOWN_ENDPOINT Reason to error responses from the bridge.
  2. Recognizing these errors in jicofo and handling them differently (only re-invite that single endpoint)

Should it be a new condition in this case for first part? as jvb during generation exception has the comment that it should be Condition.item_not_found but this conflicts with some error codes from the Muc.

from jicofo.

bgrozev avatar bgrozev commented on June 29, 2024

Item_not_founds is fine, as long as it also has a colibri2 error extension specifying that it's about an endpoint

from jicofo.

mykhailo-ua avatar mykhailo-ua commented on June 29, 2024

Item_not_founds is fine, as long as it also has a colibri2 error extension specifying that it's about an endpoint

do we need return specific endpoint id from the jvb?

from jicofo.

mykhailo-ua avatar mykhailo-ua commented on June 29, 2024

Added proposed prs

from jicofo.

bgrozev avatar bgrozev commented on June 29, 2024

The PRs have been merged now, thanks @mykhailo-ua !

from jicofo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.