Seg fault when using the packed arguments calling convention about halide-hls

[jingpu]

@jeffsetter Could you please take a look at this?

[jeffsetter]

Yea I can take a look

[jeffsetter]

I was able to fix it by using the code below. However, it appears that there is a problem now when I attempt to cast a void* that was originally a Image<uint8_t>* to a buffer_t** in pipeline_hls.cpp with the function __pipeline_hls_argv.
However, by doing the conversion to buffer_t* first (as below), it appears to work. Do you have any suggestions on a cleaner way to do this? The code below seems a bit ugly.

buffer_t* in_buf = in;
buffer_t* weight_buf = weight;
uint16_t bias = 0;
buffer_t* out_hls_buf = out_hls;

void** arg_values = new void*[4];
arg_values[0] = (void*) &in_buf;
arg_values[1] = (void*) &weight_buf;
arg_values[2] = (void*) &bias;
arg_values[3] = (void*) &out_hls_buf;
pipeline_hls_argv(arg_values);
delete [] arg_values;

[jingpu]

I find how the master branch does the _argv calling. Could you match their implementation?
https://github.com/jingpu/Halide-HLS/blob/HLS/test/generator/argvcall_aottest.cpp#L44

[jeffsetter]

I still need to cast to buffer_t* first (because my implementation uses buffer_t**), but it's a bit cleaner now.

// cast first to buffer_t*
buffer_t* in_buf = in;
buffer_t* weight_buf = weight;
uint16_t bias = 0;
buffer_t* out_hls_buf = out_hls;

void* arg_values[4] = { &in_buf, &weight_buf, &bias, &out_hls_buf };
pipeline_hls_argv(arg_values);

[jingpu]

Can you use buffer_t* instead of buffer_t**?

[jeffsetter]

I changed Codegen_C to use buffer_t* instead, pushed the change, and now am waiting on travis.

[jeffsetter]

Travis passed, so I'll close this.

[jingpu]

Thanks!

…

On Apr 20, 2017 1:17 PM, "Jeff Setter" ***@***.***> wrote: Travis passed, so I'll close this. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACDjaN-4tdquWhpl3VcOnITLctVfMxNcks5rx71ygaJpZM4M_---> .