Unable to show Confetti - No Crash No Confetti. about confetti

[michielibiza]

@jinatonic
I have a similar problem: I'm following the advice of the readme but no confetti is renered. I tried on Nexus 5X with android 7 using this code from the read me:
CommonConfetti.rainingConfetti(root, new int[] {Color.BLACK }).infinite();

after some debugging I think the problem lies in the timing: often final long elapsedTime = valueAnimator.getCurrentPlayTime(); in the update listener in startAnimation is 0. Which prevents particle emission. And sometimes the time is not 0 but the lastEmittedTimestamp in processNewEmission == 0, with the same effect...

[michielibiza]

I found the problem. The sample code does not work from Activity::onCreate only by starting it later (like the sample project) did I manage to show the confetti

[jinatonic]

Yeah the problem with onCreate is that the view hasn't been measured yet so the confetti manager doesn't know the bounds to show the confetti in.

…

On Fri, Apr 7, 2017, 11:57 PM Michiel van Liempt ***@***.***> wrote: I found the problem. The sample code does not work from Activity::onCreate only by starting it later (like the sample project) did I manage to show the confetti — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTH5TFp2Ir9eyVlfvmBJEjTUVTAiHyuks5rtk7OgaJpZM4MTVnr> .

[michielibiza]

Yes, I understand... Maybe it's something to put in the read me ;)

…

On Sat, Apr 8, 2017 at 4:04 AM Jin Cao ***@***.***> wrote: Yeah the problem with onCreate is that the view hasn't been measured yet so the confetti manager doesn't know the bounds to show the confetti in. On Fri, Apr 7, 2017, 11:57 PM Michiel van Liempt ***@***.*** > wrote: > I found the problem. The sample code does not work from Activity::onCreate > only by starting it later (like the sample project) did I manage to show > the confetti > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#18 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/ABTH5TFp2Ir9eyVlfvmBJEjTUVTAiHyuks5rtk7OgaJpZM4MTVnr > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFNz7LTa85KlRb1XuZD6ELje2kXa4RYrks5rtusdgaJpZM4MTVnr> .

[jinatonic]

Haha good point, I'll add it so people avoid that pitfall.

[jughoor]

how do i show this anim in onCreate method ????