Comments (6)
hmm,
Using whitespace with closure-compiler is not a solution since it will not transpile es6 down to old syntax. But i saw a option for pretty print...
Would a source map be a solution also?
from formdata.
It is best practice not to ship minified (or bundled) code to npm; that is best performed by the consumer in their project.
I suggest removing the build script and minified file. If the source needs to be transpiled, you can use Babel dev dependencies and setup a prepare
package script. That way users can install this package as a git dependency to try out forks/PRs, etc.
from formdata.
It is best practice not to ship minified (or bundled) code to npm; that is best performed by the consumer in their project.
I did that before, it ended up with ppl complaining that the polyfill didn't work in there build step - they might just have used a simple gulp script to concatenate all files without babel or something like it
I suggest removing the build script and minified file. If the source needs to be transpiled, you can use Babel dev dependencies and setup a
prepare
package script. That way users can install this package as a git dependency to try out forks/PRs, etc.
I'm not keen to switch to using another compiler. and ppl are probably already hot linking to github using jsdelivr so i'm not removing the minified file either - and i will keep updating the minified file for future references
if you don't want to use the minifed version you could always include the es6 version right await
require('formdata-polyfill/FormData.js')
Another idea maybe is to change the code to be written with es5 instead - thoughts?
from formdata.
I did that before, it ended up with ppl complaining that the polyfill didn't work in there build step - they might just have used a simple gulp script to concatenate all files without babel or something like it
It sounds like you were publishing untranspiled source code. You should publish transpiled code, just don't minify (or bundle) it.
The generally accepted standard for published code used to be ES5. But best practice today is to establish a browserslist query, and let @babel/preset-env transpile the source code to your chosen level of browser support. Personally I use > 0.5%, not dead, node 6
:
https://github.com/jaydenseric/extract-files/blob/v5.0.1/package.json#L35
Something else good to do is to publish native ESM in sibling .mjs
files. You do all the the other transpilations except you retain the ESM syntax:
https://github.com/jaydenseric/extract-files/blob/v5.0.1/package.json#L60
https://github.com/jaydenseric/extract-files/blob/v5.0.1/babel.config.js#L7
from formdata.
It sounds like you were publishing untranspiled source code. You should publish transpiled code, just don't minify (or bundle) it.
Correct - Personally I rather have a sourcemap that points to the actual part of the code rather then to some place in the transpiled place
from formdata.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from formdata.
Related Issues (20)
- Exclude Disabled Fieldset Descendent Controls HOT 10
- in ios 10.3 formData be text/plain HOT 2
- handle empty fileList HOT 1
- IE11 empty request body HOT 6
- Not IE Safe HOT 3
- [Suggestion] Add more per-entry headers HOT 1
- Suggest adding boundary setter and getter HOT 2
- IE11 upload failing in version 4.0.1 HOT 4
- encode headers more correctly HOT 2
- run test agains WPT
- 4.0.5 is broken HOT 1
- Use Github CI HOT 1
- TypeScript types not published HOT 2
- The automated release is failing 🚨
- Is this program support IE11? HOT 3
- error TS2322: Type 'FormData' is not assignable to type 'BodyInit'. HOT 1
- Request fails while using `fs.createReadStream` HOT 3
- How to send a form with additional headers in node.js with fetch HOT 2
- Example in the readme is confusing HOT 4
- `SyntaxError: Invalid regular expression` in Safari HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formdata.