Comments (3)
Hey there, sorry for the delay. Due to work and personal schedules, I haven't been able to work on scrollnav in a long time and stopped working on new features entirely. If you'd like to make the necessary changes and send a PR I'd be happy to look them over. Thank you for understanding.
from scrollnav.
I think it's better to talk about 'implementing infinite level depth' instead of 'implementng a 3rd layer'. That leads to the question of the interface.
Currently, the 1st level is specified in 'sections' and the second level in 'subSections'.
I assume that the interface has to be kept stable, in order not to break existing installations when updating.
My proposal on that would be, that 'sections' will take an argument that consists of one or more space-separated html-tags. E.g: 'h1 h2 h3 h4 h5' or 'article section'.
Behaviour:
- If none is present it default to h2 (current behaviour)
- If exactly one is present, use it as first level, check subSections for second level
- If more than one is present, use them in the given order as levels. Ignore subSection.
Any better ideas?
from scrollnav.
@makrohard that could make sense, but I'd prefer it to be in an array form so the plugin doesn't need to do much format checking. I'm open to a PR demonstrating this idea if you have the time to try it.
from scrollnav.
Related Issues (20)
- Allow customization of CSS classes HOT 5
- Accessibility: how to give focus to the selected heading HOT 5
- Subsections in nested elements are not recognized HOT 2
- Disable scroll animation HOT 2
- Feature request: Set target position of the element which can be scrolled to HOT 1
- avoid innerHTML in order to pass strict CSP-Header HOT 2
- Bug on scroll and click HOT 1
- Cannot modify Offset HOT 1
- fix can not scroll to the right position
- Are wrappers really needed? HOT 4
- f.nextUntil(...).andSelf is not a function (jQuery v3 incompatibility) HOT 6
- Error when running `grunt default` (for development) HOT 1
- Testing Octobox HOT 1
- v3 Request for feedback HOT 7
- Overhaul Toolchain HOT 2
- Setup unit tests HOT 1
- Add getOrSetID function HOT 1
- Add browser compatibility info (especially IE) HOT 7
- It should have a dancing attribute. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scrollnav.