Bad quality of the image on iOS about react-native-image-marker

[JimmyDaddy]

The new version 0.1.4 fixed this problem, and I'll optimize the API to support pass quality at the next version

[JimmyDaddy]

@sunkibaek thanks for your suggestion, I'll check this later and try to fix it

[sunkibaek]

@JimmyDaddy

Might the line below be the reason?

https://github.com/JimmyDaddy/react-native-image-marker/blob/master/ios/RCTImageMarker/RCTImageMarker.m#L53

Since the documentation says that the quality is the amount between 0 and 1 and we are passing 0.1 effectively.

https://developer.apple.com/documentation/uikit/1624115-uiimagejpegrepresentation

[richardkarsten]

It's definitely the line mentioned by @sunkibaek. Since I'am not a Objective C/native iOS developer I didn't find out, where the value of "quality" is defined or generated but I changed the line from

NSData* data = UIImageJPEGRepresentation(image, quality / 100.0);
to
NSData* data = UIImageJPEGRepresentation(image, 1.0);

Result:

quality/100.0 seems like there was planned a possibility to pass the quality to the function.

[JimmyDaddy]

Sorry for the late response. I'll check it and fix this issue

[Andrfas]

@JimmyDaddy thank you for the updates!

Am I right that there are two more places to update the code from 1 to 100?
https://github.com/JimmyDaddy/react-native-image-marker/blob/master/ios/RCTImageMarker/RCTImageMarker.m#L364
https://github.com/JimmyDaddy/react-native-image-marker/blob/master/ios/RCTImageMarker/RCTImageMarker.m#L409

Thanks!

[JimmyDaddy]

T_T, I'm sorry for this mistake, I'm too busy recently.

[JimmyDaddy]

Hello, 0.2.0 may be fixed this problem, and there are some changes of usage