capture_preview() broken in v2.5.0 about python-gphoto2

[jim-easterbrook]

This is because capture_preview now has two optional parameters - a CameraFile and a Context (or GPContext). If you need to pass a Context you also need to pass a CameraFile, which can be created with camera_file = gp.CameraFile(). In this case the CameraFile object is not returned by capture_preview.

The "pythonic" way to do this would be with named/keyword parameters. I'll investigate if I can do this with SWIG.

You don't normally need a Context - it's only used if you need callbacks during some functions.

[jim-easterbrook]

You can also use None instead of a CameraFile object. capture_preview will then behave as before, returning a new CameraFile object.

[jim-easterbrook]

The "pythonic" way to do this would be with named/keyword parameters. I'll investigate if I can do this with SWIG.

SWIG can create keyword arguments, but it's an all or nothing option. Changing all python-gphoto2 function arguments to keyword arguments would be a big change (and wouldn't allow overloaded functions that are currently used).

[Sparkofska]

Great! Thanks for the instant response!

Passing None instead of CameraFile works.

Thanks also for the hint of not needing a Context. I removed this variable entirely and it still works :)