Coder Social home page Coder Social logo

Comments (9)

daniellacosse avatar daniellacosse commented on July 28, 2024

Thanks for the question! Where are you running maccatalyst?

Try editing the config.xml, like this: d378ced

from outline-client.

sbruens avatar sbruens commented on July 28, 2024

We don't currently set the name on the manager, which is why it defaults back to the app's name. You can set it by configuring the localizedDescription on the NETunnelProviderManager:

https://github.com/Jigsaw-Code/outline-client/blob/6356371797cf882a9472f8be4aa9f8c7bbfb3d21/src/cordova/apple/OutlineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift#L196

To change the server address, update serverAddress:

https://github.com/Jigsaw-Code/outline-client/blob/6356371797cf882a9472f8be4aa9f8c7bbfb3d21/src/cordova/apple/OutlineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift#L194

from outline-client.

sbruens avatar sbruens commented on July 28, 2024

For the icons Cordova takes the source images and turns them into an asset catalog and we rsync some files in that Cordova doesn't yet support (yes, it's not great 👎). You can see the output of that under ./platforms/ios/Outline/Assets.xcassets/AppIcon.appiconset in your local folder. if you updated the icons after running the project, try re-running the Cordova setup again as per the README to see if they get updated properly.

You can double-check what they look like in the asset viewer:

AppIcon.

Note that a Catalyst app is a macos app, so uses the macos icons. Do those look like your new icons or are they missing, in which case it might be defaulting to another icon?

from outline-client.

suki-neithnet avatar suki-neithnet commented on July 28, 2024

We don't currently set the name on the manager, which is why it defaults back to the app's name. You can set it by configuring the localizedDescription on the NETunnelProviderManager:

https://github.com/Jigsaw-Code/outline-client/blob/6356371797cf882a9472f8be4aa9f8c7bbfb3d21/src/cordova/apple/OutlineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift#L196

To change the server address, update serverAddress:

https://github.com/Jigsaw-Code/outline-client/blob/6356371797cf882a9472f8be4aa9f8c7bbfb3d21/src/cordova/apple/OutlineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift#L194

Set localizedDescription on the NETunnelProviderManager seems not work here.

outline-permisson-ask

settings

from outline-client.

suki-neithnet avatar suki-neithnet commented on July 28, 2024

For the icons Cordova takes the source images and turns them into an asset catalog and we rsync some files in that Cordova doesn't yet support (yes, it's not great 👎). You can see the output of that under ./platforms/ios/Outline/Assets.xcassets/AppIcon.appiconset in your local folder. if you updated the icons after running the project, try re-running the Cordova setup again as per the README to see if they get updated properly.

You can double-check what they look like in the asset viewer:

AppIcon.

Note that a Catalyst app is a macos app, so uses the macos icons. Do those look like your new icons or are they missing, in which case it might be defaulting to another icon?

Here's my config.xml
config-icon-settings-screenshot

And under ./platforms/ios/Outline/Assets.xcassets/AppIcon.appiconset, except some watchOS icon remain empty, other icons all changed to my custom icon, but it still not change the icon in Settings > Network > VPN and info.
assests-screenshot

settings

from outline-client.

sbruens avatar sbruens commented on July 28, 2024

I wonder if you previously created the profile with the Outline config. Try removing it in the VPN settings. It will then create a new one on the first attempt to connect and will likely use your new config to do so. I think that is probably the issue for both the icon and the name.

from outline-client.

suki-neithnet avatar suki-neithnet commented on July 28, 2024

I wonder if you previously created the profile with the Outline config. Try removing it in the VPN settings. It will then create a new one on the first attempt to connect and will likely use your new config to do so. I think that is probably the issue for both the icon and the name.

I think this is not the problem here, because I remove the VPN settings every time before I rebuild, and it still not working.
But the name in vpn permision ask changed correctly after I clean all build folder under ~/Library/Developer/Xcode/DerivedData/.
But the icon and name in VPN settings still not changed.

from outline-client.

daniellacosse avatar daniellacosse commented on July 28, 2024

@suki-neithnet Hey, did you figure this out?

from outline-client.

suki-neithnet avatar suki-neithnet commented on July 28, 2024

@suki-neithnet Hey, did you figure this out?

Uh ... not yet, I've filled all icon fields in assets folder, but even if I remove then rebuild it again and again. It still not working.

from outline-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.