Comments (6)
Hi and thanks for submitting the issue!
I generated the tables from CSV files downloaded from a third party website, which seemingly did not include the links. I did not have any reference library to build from, so the absence never came up.
Testing the underlying Offset code in Go Playground shows that the link locations can be parsed with Go's time
package. Therefore, I agree that the links should be added.
I wouldn't mind a pull request, but I'll try to be productive enough to add the missing locations by myself during this week.
from timezone.
Cool. I don’t think I’ll be able to submit a contribution, sorry. But thanks!
from timezone.
Hi again,
It looks like there would be 88 location additions, including the following for US:
US/Alaska
US/Aleutian
US/Arizona
US/Central
US/East-Indiana
US/Eastern
US/Hawaii
US/Indiana-Starke
US/Michigan
US/Mountain
US/Pacific
US/Pacific-New
US/Samoa
Do you notice anything missing?
I did remove few backwards compatible entries such as these, since most of them aren't really locations, which makes time inaccurate. The updated location list array will be made from the following file: https://github.com/9uuso/timezone/blob/dev/2015e/loc
Can you check are the backwards compatible timezones listed in your frontend library? If they are, I have to figure out how to deal with the backward compatible zones.
If these changes satisfy you, I'll generate the Go code and merge the changes.
from timezone.
Honestly I think rather than try to base the list on any given client behavior, we should stick with the canonical IANA list. I’m hoping that the Wikipedia page is an accurate representation of that list.
I extracted a list of all the values from that page. I count 538 values in that list, whereas the file you linked in your dev branch has only 504.
My preference would be for the lib to include all 538 values listed in the Wikipedia page.
from timezone.
I downloaded the latest package from IANA (version 2015e -- Wikipedia has 2014b) and updated the locations to include timezone links. The new array is 584 elements long and includes the timezones that you were missing.
from timezone.
from timezone.
Related Issues (2)
- Timezone data error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from timezone.