add #discard! about discard

[artemf]

@rlue Actually, even simple validation error can break the deletion, which is odd to say the least. I've looked at the code and it does simple #save to "soft-delete" the record, meaning a) validation error can break soft-deletion, b) any update callback can break (stop) soft-deletion, c) else?

The author seem to have a very particular idea about how to implement soft-deletion (which he calls "done right"), but validations breaking the deletion look very wrong to me.

[jhawthorn]

Sounds great!

[rlue]

I'm curious: under what conditions might you expect #discard to fail (other than, say, running out of database connections or some kind of network failure between app/DB servers)?

[goravbhootra]

@rlue calling discard on a non-existent id. bang method definitely has its use cases.

[rlue]

@artemf that's an interesting point. What do you think the correct behavior should be? Bypass validation on discard (e.g., via #update_columns) and validate on restore?

[artemf]

@rlue I would check how destroy is performed in rails and would design the call in a similar way (callbacks, etc.). Running update hooks on #discard! Really? But that's what this gem (~ regular #save) is doing.

[skatkov]

@artemf I've been looking at paranoia gem before and wrote my own implementation that is very similar to discard approach. I never had a real world scenario, then I had to update data and discard a record at the same time (so i never ran into issue your mentioning).

While I agree with you notion. Have you experienced issues with behavior you mention here?