Comments (2)
Sorry that your site got deleted. What was the setting for the system settings: databackup.folder? Was this the root path of your site?
I will look to a a safe gaurd that the MODX root, manager, core and assets folders can not be used but only a nested folder with in it.
from databackup.
Thanks. Luckily my host keeps 24 hour backups, and I didn't lose much information at all.
I was trying to store the backups outside of the web root, but I couldn't work out where the backups were being stored, so I tried a number of directories, including / . Given that the rmdir deleted email accounts as well, it's possible that this was where the error occurred.
I would highly recommend finding a safeguard against the rmdir that stops the snippet deleting anything without admin approval, and particularly anything that runs as a background or automatic process in this case. Rmdir is a dangerous command and needs to be treated as such. Maybe instead of an automated cleanup process, a plug in could be used to track the number of backup files and provide a warning/dialogue that allows admin to clean up the backups?
Can I also suggest you put a warning out as best as possible to those using the snippet currently or those about to download it? I was lucky, my host kept back ups. The next person might not be so lucky.
jgulledge19 [email protected] wrote:
Sorry that your site got deleted. What was the setting for the system settings: databackup.folder? Was this the root path of your site?
I will look to a a safe gaurd that the MODX root, manager, core and assets folders can not be used but only a nested folder with in it.
—
Reply to this email directly or view it on GitHub.
from databackup.
Related Issues (7)
- add to RTFM HOT 1
- no data backed up HOT 1
- [feature] fetch specific tables HOT 2
- databackup.pruge => databackup.purge HOT 2
- dupe - pls ignore
- Improve memory useage HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from databackup.