Comments (3)
Hey @casbboy, do you have a page or anything up that shows the problem? I built the plugin against video.js 5, and notice you're using video.js 6 syntax for the #addChild function. The indexopt (4) wasn't available when originally built, so this line is responsible for placing the theater mode button just before the fullscreen button:
https://github.com/jgubman/videojs-theater-mode/blob/master/src/videojs.theaterMode.js#L49
Here's what it's supposed to look like:
video.js 6.2: https://jsfiddle.net/qwv0n9m3/2/
video.js 5.19: https://jsfiddle.net/qwv0n9m3/
from videojs-theater-mode.
Hey @jgubman - It turns out a skin I had wasn't completing before running yours, so the skin had the same line for two other buttons, and so they'd get priority since would run after the theater mode button.
The skin has since added a "finished" trigger, so I wait for that and then run the theatermode.
I used to have my expand player function inside this:
player.on('theaterMode', function(elm, data) {
if (data.theaterModeIsOn) {
expandtaplayer();
} else {
expandtaplayer();
}
But it would run upon load every time, so deleted the above and just went with....
$(document).on('click', ".vjs-theater-mode-control-open,.vjs-theater-mode-control-close", function() {
expandtaplayer();
});
Since that single function checks whether expanded or not yet.
Cheers!
Ryan
from videojs-theater-mode.
You can see the theater mode button in action here: https://www.traileraddict.com/thor-ragnarok/feature-trailer
from videojs-theater-mode.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from videojs-theater-mode.