Coder Social home page Coder Social logo

Comments (8)

jgoodman8 avatar jgoodman8 commented on June 19, 2024

Thanks a lot for your interest in the project, @bastienboutonnet!

Yes, the support of pre-releases and specific tags are in the support plan. This is just the very first release.
The idea would be providing something similar to what the standard-version CLI provides. For example:

Release as Pre-Release

pyhist --update --prerelease  # 1.0.0 -> 1.0.0-0
pyhist --update --prerelease alpha  # 1.0.0 -> 1.0.0-alpha.0

Release as specific version

pyhist --update --release-as 1.1.1a1  # 1.0.0 -> 1.0.0-1a1

If you want, you are completely free to contribute. Let's keep talking

from pyhist.

bastienboutonnet avatar bastienboutonnet commented on June 19, 2024

Awesome at least if it's on the radar means you're not against it hehe

Yep I'd love to contribute. From what I was able to see is that at the moment the functions that parse the versions are pretty strict. Would it make sense to allow them first to parse string like stuff?

What do you see might be the best way to have a stab at it.

Also am I right that update also acts as a bump version like thing? (I'm on my phone so it's shitty to check code right now) but yes would love to help!

from pyhist.

jgoodman8 avatar jgoodman8 commented on June 19, 2024

Sorry for my late response.

Yes, indeed the update command acts as a version bump.

I haven't seen the output error when you execute pyhist init, but I guess it's due to the parse of the current version. Currently, this is how the setup.py version is parsed:

def get_current_version_parts(self) -> Tuple[int, int, int]:
    version_str = self._get_version_str()
    return [int(version_part) for version_part in version_str.split(".")]

To support "custom" versions, we would need to change a couple of things:

  • differentiate standard versions and custom versions in history
  • change version parse method
  • change init method
  • add update to a specific version

from pyhist.

bastienboutonnet avatar bastienboutonnet commented on June 19, 2024

No worries at all @jgoodman8

The error output, which I don't have handy right now, was indeed coming from this part of the stack I believe, at least it looks familiar.

It seems pretty "straighforward". If you're into it I could try and find some time to have a go at it some day (probably next weekend or so)

from pyhist.

jgoodman8 avatar jgoodman8 commented on June 19, 2024

It would be great @bastienboutonnet
Please, let me know if you have any doubts or questions.

from pyhist.

bastienboutonnet avatar bastienboutonnet commented on June 19, 2024

No woeries!

A quick one. Can you rephrase or elaborate the first todo/bullet point you made in your last message? I think the other 3 are clear to me but not sure about the first.

from pyhist.

jgoodman8 avatar jgoodman8 commented on June 19, 2024

Yep, I think it's the trickiest.
It's a big complex to write it down. So, I will try to work on the first point during this week, sounds good?

from pyhist.

bastienboutonnet avatar bastienboutonnet commented on June 19, 2024

@jgoodman8 sure no worries and no rush! I can take care of the rest after :)

from pyhist.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.