Coder Social home page Coder Social logo

Comments (14)

runiter avatar runiter commented on May 18, 2024 1

Sure thing @MairwunNx . I'm closing it and will await the new version with all the fixes and improvements.

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on May 18, 2024

@runiter Hi! Thanks for report, i already complete background color for all controls in #39
On fonts: I am aware of this problem, and I will correct it this week.

I have tables with font sizes from Fluent Design Language official documentation, and I also saw inconsistencies. This will be fixed.

from jfxtras-styles.

runiter avatar runiter commented on May 18, 2024

@MairwunNx fantastic! Thank you.
Do you have a link to the Fluent Design font size table that you can share here?

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on May 18, 2024

@runiter sure! If you need more details, I will try to search :)

image
image

from jfxtras-styles.

saeidN avatar saeidN commented on May 18, 2024

@MairwunNx neat! Thank you.
I see that Body text uses font size 15px in Fluent Design. Is this the font size that should be the default for all Labels, Buttons, TextFields, ChoiceBoxes, and CheckBoxes? Or does Fluent Design apply different font size to different control types?

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on May 18, 2024

@runiter i see UWP controls sizes:

TextBox (14px = Body but 14px).
image

CheckBox (14px = Body but 14px)
image

Button (14px = Body but 14px)
image

ComboBox (14px = Body but 14px)
image

RadioButton (14px = Body but 14px)
image

Idk why in official documentation 15px, but in official SDK controls 14, i think it mistake, but better use 14px, as on screenshots.

from jfxtras-styles.

runiter avatar runiter commented on May 18, 2024

I'm cool with 14px.
Also glad to hear that all controls have same font size :)

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on May 18, 2024

@runiter @saeidN no problem 😊

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on May 18, 2024

If problem resolved, close issue please. @runiter

from jfxtras-styles.

runiter avatar runiter commented on May 18, 2024

Sorry for the confusion with 2 accounts. "runiter" is my main account :)

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on May 18, 2024

No problem, i understand @runiter :)

from jfxtras-styles.

dukke avatar dukke commented on May 18, 2024

Hi @runiter,

Could you please file an issue about the mismatch in font sizes in different controls and another one regarding different controls having different sizes (2 issues).

As Pavel said, we're already working on changing the background color of controls so no need to file that one.

Thanks.

from jfxtras-styles.

runiter avatar runiter commented on May 18, 2024

@dukke sure thing.

from jfxtras-styles.

dukke avatar dukke commented on May 18, 2024

Thanks

from jfxtras-styles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.