Support for method and path combination about express-unless

[mindmelting]

+1

[goncaloneves]

+1

[mikelax]

+1, just ran into this today. For the time being I will write a custom function to achieve the desired logic, but it seems like a simple addition of another attribute.

[razvanilin]

+1

[emaddoma]

+1

[goncaloneves]

The way I accomplished this with a custom unless function:

app.use(middleware().unless(function(req) {
  return (
      req.originalUrl === '/endpoint1' && req.method === 'GET' ||
      req.originalUrl === '/endpoint2' && req.method === 'POST'
  );
}));

Hope it helps.

[chuckconway]

@goncaloneves Thanks for the code. It works, but it would be nice if it was baked in.

[zhiyelee]

@chuckconway @goncaloneves feature added in v0.3

[molaeiali]

I'm using unless with express-jwt to whitelist some endpoints from having to have token, but looks like it does not respect the http method I provide

app.use(
    jwt({
      secret: process.env.JWT_SECRET
    }).unless({
       path: [
            //...
           { url: 'estimate/category', method: 'GET' },
            //...
       ]
    })

as I understand, it should whitelist 'estimate/category' just for GET method, in other words, I have to provide token if it is POST or PATCH and don't have to provide token if it's GET

but it is whitelisting it for all methods.

I think the problem is here:

express-unless/index.js

Line 42 in 04b49c4

skip = skip || methods.indexOf(req.method) > -1;

Shouldn't it be a && here?
This code says here if skip exists, methods are not important

Environment

I'm using:
"express": "4.17.1",
"express-jwt": "5.3.3",
"express-unless":"0.3.1"